Merge lp:~patrik-ryd/linaro-android-build-tools/linaro-android-build-tools into lp:linaro-android-build-tools

Proposed by Patrik Ryd
Status: Merged
Merged at revision: 518
Proposed branch: lp:~patrik-ryd/linaro-android-build-tools/linaro-android-build-tools
Merge into: lp:linaro-android-build-tools
Diff against target: 11 lines (+1/-0)
1 file modified
build-scripts/create-user-build-script (+1/-0)
To merge this branch: bzr merge lp:~patrik-ryd/linaro-android-build-tools/linaro-android-build-tools
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+127740@code.launchpad.net

Description of the change

Suggestion for a bugfix for Bug #1060272. I have no way of testing that it actually works.

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

change looks good to me.
Will ask also Paul to chime in since he knows better android-build, but I guess that as long as the Android build tools interpret BUILD_TINY_ANDROID correctly, it can be tested as soon as the code is merged. The only thing that I'm not sure about is if we have to specify BUILD_TINY_ANDROID in the make command (function build_commands), or if it just picks it up from the environment.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good. I assume the idea of this patch is to propagate BUILD_TINY_ANDROID setting from the original build config down to user rebuild script. As Milo, I'm not sure how it is actually handled, but I assume it is.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/create-user-build-script'
2--- build-scripts/create-user-build-script 2012-06-14 10:25:06 +0000
3+++ build-scripts/create-user-build-script 2012-10-03 12:30:33 +0000
4@@ -97,6 +97,7 @@
5 export MANIFEST_FILENAME=${MANIFEST_FILENAME}
6 export TARGET_PRODUCT=${TARGET_PRODUCT}
7 export TARGET_SIMULATOR=false
8+export BUILD_TINY_ANDROID=${BUILD_TINY_ANDROID}
9 export CPUS=\`grep -c processor /proc/cpuinfo\`
10 EOF
11 if [ -n "$TOOLCHAIN_URL" ] ; then

Subscribers

People subscribed via source and target branches