Code review comment for lp:~patrick-hetu/charms/precise/python-django/pure-python

Revision history for this message
Patrick Hetu (patrick-hetu) wrote :

> It seems that the tests are failing on AWS and HPCloud due to the django.yaml
> bundle not including "expose: true" directives; the services get started up
> but can't be connected to because they are not exposed. They did all pass for
> me on local provider, where expose isn't necessary.

ah! I did not know about this one. I've fixed it in the latest commit of this branch.

> I also wanted to note that the tests indicate that the `juju ssh` command
> ought to be updated once https://bugs.launchpad.net/juju-core/+bug/1281577 is
> resolved, but it seems that was fixed several releases ago. I'm assuming this
> is carry-over from older tests, and it doesn't affect their function. Just
> wanted to mention it for future test changes.

ok

« Back to merge proposal