Juju Charms Collection
python-django package

Code review comment for lp:~patrick-hetu/charms/precise/python-django/pure-python

  1. Precise Pangolin (12.04)
  2. pure-python
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

Patrick,

Thanks for your work on this charm!

It seems that the tests are failing on AWS and HPCloud due to the django.yaml bundle not including "expose: true" directives; the services get started up but can't be connected to because they are not exposed. They did all pass for me on local provider, where expose isn't necessary.

I also wanted to note that the tests indicate that the `juju ssh` command ought to be updated once https://bugs.launchpad.net/juju-core/+bug/1281577 is resolved, but it seems that was fixed several releases ago. I'm assuming this is carry-over from older tests, and it doesn't affect their function. Just wanted to mention it for future test changes.

review: Needs Fixing

« Back to merge proposal