Juju Charms Collection
python-django package

Code review comment for lp:~patrick-hetu/charms/precise/python-django/pure-python

  1. Precise Pangolin (12.04)
  2. pure-python
  3. Merge into trunk
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

Hi Patrick,

Thanks for working on this charm! Before proceeding with this review we'll need to get the tests passing. Here's what I found:

* `charm-proof` fails:

W: config.yaml: option django_allowed_hosts does not have the keys: default
W: config.yaml: option django_extra_settings does not have the keys: default
W: config.yaml: option unit-config does not have the keys: default

* `make lint` and `make test` fail. It's important to make these pass as they will be executed by our automated charm testing system.

* functional test failures:

01-dj13 Deployment timed out
10-mysql Deployment timed out
10-postgresql Install hook failure

The other functional tests passed for me. My testing was on lxc - if these tests pass for you on a different provider, please let me know.

Thanks again for your effort on this charm. Looking forward to continuing this review once the tests are fixed up!

review: Needs Fixing

« Back to merge proposal