Merge lp:~patrick-crews/drizzle/dbqp_freebsd_ports into lp:drizzle/7.0

Proposed by Patrick Crews
Status: Merged
Approved by: Lee Bieber
Approved revision: 2122
Merged at revision: 2123
Proposed branch: lp:~patrick-crews/drizzle/dbqp_freebsd_ports
Merge into: lp:drizzle/7.0
Diff against target: 33 lines (+11/-1)
2 files modified
tests/lib/sys_mgmt/port_management.py (+10/-1)
tests/lib/sys_mgmt/system_management.py (+1/-0)
To merge this branch: bzr merge lp:~patrick-crews/drizzle/dbqp_freebsd_ports
Reviewer Review Type Date Requested Status
Drizzle Developers Pending
Review via email: mp+47724@code.launchpad.net

Description of the change

Fixes how we parse netstat output during port allocation checks.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/lib/sys_mgmt/port_management.py'
2--- tests/lib/sys_mgmt/port_management.py 2011-01-21 18:47:56 +0000
3+++ tests/lib/sys_mgmt/port_management.py 2011-01-27 20:39:58 +0000
4@@ -107,7 +107,16 @@
5 if entry.startswith('Proto'):
6 good_data = 1
7 elif good_data:
8- used_port = int(entry.split()[3].split(':')[-1].strip())
9+ # We try to catch additional output
10+ # like we see with freebsd
11+ if entry.startswith('Active'):
12+ good_data = 0
13+ pass
14+ else:
15+ if self.system_manager.cur_os == 'FreeBSD':
16+ used_port = int(entry.split()[3].split('.')[-1].strip())
17+ else:
18+ used_port = int(entry.split()[3].split(':')[-1].strip())
19 if port == used_port:
20 if entry.split()[-1] != "TIME_WAIT":
21 return 1
22
23=== modified file 'tests/lib/sys_mgmt/system_management.py'
24--- tests/lib/sys_mgmt/system_management.py 2011-01-26 01:13:20 +0000
25+++ tests/lib/sys_mgmt/system_management.py 2011-01-27 20:39:58 +0000
26@@ -49,6 +49,7 @@
27 self.env_var_delimiter = ':'
28 self.no_shm = variables['noshm']
29 self.shm_path = self.find_path(["/dev/shm", "/tmp"], required=0)
30+ self.cur_os = os.uname()[0]
31 self.symlink_name = 'dtr_work_sym'
32 self.workdir = variables['workdir']
33 self.start_dirty = variables['startdirty']

Subscribers

People subscribed via source and target branches