Merge lp:~patrick-crews/drizzle/dbqp_bug710942 into lp:drizzle/7.0

Proposed by Patrick Crews
Status: Merged
Approved by: Lee Bieber
Approved revision: 2133
Merged at revision: 2132
Proposed branch: lp:~patrick-crews/drizzle/dbqp_bug710942
Merge into: lp:drizzle/7.0
Diff against target: 38 lines (+12/-4)
2 files modified
tests/lib/server_mgmt/server_management.py (+4/-1)
tests/lib/sys_mgmt/port_management.py (+8/-3)
To merge this branch: bzr merge lp:~patrick-crews/drizzle/dbqp_bug710942
Reviewer Review Type Date Requested Status
Drizzle Developers Pending
Review via email: mp+48073@code.launchpad.net

Description of the change

updates to server management code to deal with a situation where the server wasn't running, but the server_manager didn't know to restart it : (

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/lib/server_mgmt/server_management.py'
2--- tests/lib/server_mgmt/server_management.py 2011-01-27 20:13:55 +0000
3+++ tests/lib/server_mgmt/server_management.py 2011-01-31 22:39:38 +0000
4@@ -131,8 +131,11 @@
5 while not server.ping(quiet= True) and attempts_remain:
6 time.sleep(1)
7 attempts_remain = attempts_remain - 1
8- if server.status == 1 or server.ping(quiet=True):
9+ if server.ping(quiet=True):
10 server.stop()
11+ else:
12+ # make sure the server is indicated as stopped
13+ server.status = 0
14
15 def stop_servers(self, requester):
16 """ Stop all servers running for the requester """
17
18=== modified file 'tests/lib/sys_mgmt/port_management.py'
19--- tests/lib/sys_mgmt/port_management.py 2011-01-29 20:26:04 +0000
20+++ tests/lib/sys_mgmt/port_management.py 2011-01-31 22:39:38 +0000
21@@ -130,9 +130,14 @@
22 if self.system_manager.cur_os in [ 'FreeBSD'
23 , 'Darwin'
24 ]:
25- used_port = int(entry.split()[3].split('.')[-1].strip())
26- else:
27- used_port = int(entry.split()[3].split(':')[-1].strip())
28+ split_token = '.'
29+ else:
30+ split_token = ':'
31+ port_candidate = entry.split()[3].split(split_token)[-1].strip()
32+ if port_candidate.isdigit():
33+ used_port = int(port_candidate)
34+ else:
35+ used_port = None # not a value we can use
36 if port == used_port:
37 if entry.split()[-1] != "TIME_WAIT":
38 return 1

Subscribers

People subscribed via source and target branches