Merge lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144 into lp:ubuntu/precise/avidemux

Proposed by pataquets on 2012-08-26
Status: Work in progress
Proposed branch: lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144
Merge into: lp:ubuntu/precise/avidemux
Diff against target: 26 lines (+7/-1)
2 files modified
avidemux2-gtk.desktop (+1/-1)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144
Reviewer Review Type Date Requested Status
Marc Deslauriers Needs Fixing on 2013-05-22
Ubuntu branches 2012-08-26 Pending
Review via email:

Commit message

Allow avidemux2_gtk to be selected from 'Open with' tab (LP: #1041144)

Description of the change

Add %U to Exec[$e] line to allow avidemux2_gtk binary to be listed in 'Open with' program list

To post a comment you must log in.
Dmitry Shachnev (mitya57) wrote :

Thanks for your work here, some comments:

- The format is 3.0 (quilt), so instead of modifying files in-place you should create a quilt patch (like done in lp:ubuntu/avidemux).
- Did you discuss this change with upstream?

pataquets (pataquets) wrote :

I'm a newbie packager, no idea what a quilt patch is :s . Patch in Avidemux has been enhanced/made compliant by Luke.
BTW, no contact with upstream done. Should Ubuntu fixes be done upstream first? I have no idea on policies regarding this.
I've done this patch applying advice given in #ubuntu-bugs for a recent patch to lp:precise/mumble SRU.

Marc Deslauriers (mdeslaur) wrote :

Thanks for the merge request, but the desktop file needs to be modified using the patch system that's in the package. See the following page for more information on patch systems:

review: Needs Fixing

Unmerged revisions

54. By pataquets on 2013-05-15

Add changelog entry.

53. By pataquets on 2012-08-26

Allow avidemux2_gtk to be selected from 'Open with' tab

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'avidemux2-gtk.desktop'
2--- avidemux2-gtk.desktop 2009-02-17 23:41:46 +0000
3+++ avidemux2-gtk.desktop 2013-05-15 20:25:29 +0000
4@@ -2,7 +2,7 @@
5 Categories=GTK;AudioVideo
6 Comment=Per editar els vostres vídeos
7 Comment[ca]=Per editar els vostres vídeos
9+Exec[$e]=avidemux2_gtk %U
10 GenericName=Video Editor (GTK+)
11 GenericName[ca]=Editor de vídeo (GTK+)
12 Icon=avidemux
14=== modified file 'debian/changelog'
15--- debian/changelog 2012-02-09 15:38:52 +0000
16+++ debian/changelog 2013-05-15 20:25:29 +0000
17@@ -1,3 +1,9 @@
18+avidemux (1:2.5.4-0ubuntu11.1) precise; urgency=low
20+ * Allow avidemux2_gtk to be selected from 'Open with' tab (LP: #1041144)
22+ -- pataquets <> Wed, 15 May 2013 21:36:47 +0200
24 avidemux (1:2.5.4-0ubuntu11) precise; urgency=low
26 * No-change rebuild to pick libvpx's new shlib. (LP: #926580)


People subscribed via source and target branches

to all changes: