Merge lp:~parthm/bzr/format_version_tuple_import_order into lp:bzr
Proposed by
Parth Malwankar
Status: | Merged |
---|---|
Approved by: | Parth Malwankar |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5329 |
Proposed branch: | lp:~parthm/bzr/format_version_tuple_import_order |
Merge into: | lp:bzr |
Diff against target: |
35 lines (+12/-7) 1 file modified
bzrlib/__init__.py (+12/-7) |
To merge this branch: | bzr merge lp:~parthm/bzr/format_version_tuple_import_order |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Bennetts | Approve | ||
Review via email: mp+28953@code.launchpad.net |
Commit message
fixed import order of lazy_regex w.r.t _format_
Description of the change
This patch changes the import order of lazy_regex w.r.t _format_
To post a comment you must log in.
22 +# lazy_regex import must be done after _format_ version_ tuple definition version_ tuple'" error.
23 +# to avoid "no attribute '_format_
I think I'd be even more explicit here, and add " when using deprecated_function in the lazy_regex module."
There's a bit of a tension here between "install lazy_regex as early as possible (and magic the lazy_regex magic in this file as visible as possible)" and "make sure all of bzrlib/__init__.py has run before any submodules are imported" but I think this is a reasonable compromise.