Merge lp:~parthm/bzr/603461-ensure-no-var-named-message into lp:bzr
Proposed by
Parth Malwankar
Status: | Rejected |
---|---|
Rejected by: | Parth Malwankar |
Proposed branch: | lp:~parthm/bzr/603461-ensure-no-var-named-message |
Merge into: | lp:bzr |
Diff against target: |
135 lines (+65/-9) 3 files modified
NEWS (+34/-1) bzrlib/errors.py (+5/-8) bzrlib/tests/test_errors.py (+26/-0) |
To merge this branch: | bzr merge lp:~parthm/bzr/603461-ensure-no-var-named-message |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
bzr-core | Pending | ||
Review via email: mp+29624@code.launchpad.net |
Commit message
test to ensure that errors.BzrError subclasses don't use "message" as arg name for __init__ and _fmt (#603461)
Description of the change
This patch adds a test to bt.test_errors to ensure that errors.BzrError subclasses in bzrlib.errors do not have an argument named "message" for __init__ and _fmt as this causes problems with some Python versions (e.g. bug #603461).
To post a comment you must log in.
Unmerged revisions
- 5346. By Parth Malwankar
-
improved fmt_pattern and assert message.
- 5345. By Parth Malwankar
-
improved assert message.
- 5344. By Parth Malwankar
-
imporved test to check _fmt
- 5343. By Parth Malwankar
-
cleanup test case by using isclass rather than catching exception.
- 5342. By Parth Malwankar
-
updated NEWS
- 5341. By Parth Malwankar
-
test case to ensure the errors.exceptions don't use message arg name
Note that errors.LockError was using "message" and this is also changed to "msg". It doesn't break anything in bzr test suite. I am not sure if any plugins use 'LockError( message= "...")' specifically.