Merge lp:~parthm/bzr/594386-case-insensitive-ignore-doc into lp:bzr

Proposed by Parth Malwankar
Status: Rejected
Rejected by: Parth Malwankar
Proposed branch: lp:~parthm/bzr/594386-case-insensitive-ignore-doc
Merge into: lp:bzr
Diff against target: 38 lines (+13/-2)
2 files modified
NEWS (+3/-0)
bzrlib/help_topics/en/patterns.txt (+10/-2)
To merge this branch: bzr merge lp:~parthm/bzr/594386-case-insensitive-ignore-doc
Reviewer Review Type Date Requested Status
bzr-core Pending
Review via email: mp+29470@code.launchpad.net

Description of the change

=== Fixes bug #594386 ===
1. Documents case insensitive ignore pattern e.g. RE:(?i)foo
2. Adds hyperlink to python re docs

To post a comment you must log in.
Revision history for this message
Parth Malwankar (parthm) wrote :

I am rejecting this and submitting it against 2.2.

Unmerged revisions

5340. By Parth Malwankar

documented case insensitive ignore pattern.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2010-07-08 10:34:12 +0000
3+++ NEWS 2010-07-08 14:23:44 +0000
4@@ -160,6 +160,9 @@
5
6 * Added ``regression`` tag to our tags list. (Robert Collins)
7
8+* ``bzr help patterns`` now documents case insensitive ignore patterns.
9+ (Parth Malwankar, #594386)
10+
11 * Improved our release checklist to have a bit less churn and leave things
12 ready-to-go for the next action (including other people doing
13 development). (Robert Collins)
14
15=== modified file 'bzrlib/help_topics/en/patterns.txt'
16--- bzrlib/help_topics/en/patterns.txt 2010-01-02 07:36:36 +0000
17+++ bzrlib/help_topics/en/patterns.txt 2010-07-08 14:23:44 +0000
18@@ -19,10 +19,18 @@
19 /**/ - Matches 0 or more directories in a path
20 [a-z] - Matches a single character from within a group of characters
21
22-Patterns may also be Python regular expressions. Regular expression
23+Patterns may also be `Python regular expressions`_. Regular expression
24 patterns are identified by a 'RE:' prefix followed by the regular
25 expression. Regular expression patterns may not include named or
26-numbered groups.
27+numbered groups. Case insensitive ignore pattern can be specified using
28+the i flag in the pattern.
29+
30+For example, a case insensitive match for ``foo`` may be specified as:
31+
32+ RE:(?i)foo
33
34 Ignore patterns may be prefixed with '!', which means that a filename
35 matched by that pattern will not be ignored.
36+
37+.. _Python regular expressions: http://docs.python.org/library/re.html
38+