Merge lp:~parthm/bzr/564605-ignore-java-classfile into lp:bzr

Proposed by Parth Malwankar
Status: Rejected
Rejected by: Parth Malwankar
Proposed branch: lp:~parthm/bzr/564605-ignore-java-classfile
Merge into: lp:bzr
Diff against target: 25 lines (+4/-0)
2 files modified
NEWS (+3/-0)
bzrlib/ignores.py (+1/-0)
To merge this branch: bzr merge lp:~parthm/bzr/564605-ignore-java-classfile
Reviewer Review Type Date Requested Status
Vincent Ladeuil Needs Information
Review via email: mp+23761@code.launchpad.net

Description of the change

=== Fixed Bug #564605 ===
This is a trivial patch that adds *.class to the default ignore list (i.e. bzrlib.ignores.USER_DEFAULTS)

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

We have been pretty conservative about what we put in the default ignore list for performance reasons (anybody as an update on that ?).

If we start adding more regexps there it may be worth getting feedback from the mailing list first.

I'll vote 'Needs Information' and will put the mp status wip until we get it.

review: Needs Information
Revision history for this message
Parth Malwankar (parthm) wrote :

> We have been pretty conservative about what we put in the default ignore list
> for performance reasons (anybody as an update on that ?).
>

That sounds reasonable. I will reject this patch and mark the bug as invalid.

Unmerged revisions

5170. By Parth Malwankar

updated NEWS

5169. By Parth Malwankar

added *.class to default ignore list.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2010-04-20 10:30:30 +0000
3+++ NEWS 2010-04-20 12:52:21 +0000
4@@ -13,6 +13,9 @@
5 Compatibility Breaks
6 ********************
7
8+* Java class files (\*.class) are now ignored by default.
9+ (Parth Malwankar, #564605)
10+
11 New Features
12 ************
13
14
15=== modified file 'bzrlib/ignores.py'
16--- bzrlib/ignores.py 2010-03-29 00:54:27 +0000
17+++ bzrlib/ignores.py 2010-04-20 12:52:21 +0000
18@@ -92,6 +92,7 @@
19 # please keep these sorted (in C locale order) to aid merging
20 USER_DEFAULTS = [
21 '*.a',
22+ '*.class',
23 '*.o',
24 '*.py[co]',
25 '*.so',