Code review comment for lp:~parthm/bzr/300062-better-handling-for-invalid-ignore-pattern
Revision history for this message
| Parth Malwankar (parthm) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Some other things are fixed in the latest set of changes:
- `ignored` was crashing on invalid pattern.
- lock/unlock for ignore wasn't in try/finally or cleanup.
- As InvalidPattern exception is thrown from the lowest level, any uncaught regex error in bzr will give a InvalidPattern bzr error rather than stack trace. `add`, `ignore`, `ignored`, `status` catch this to give bad ignore pattern info.