Code review comment for lp:~parthm/bzr/300062-better-handling-for-invalid-ignore-pattern

Revision history for this message
Parth Malwankar (parthm) wrote :

> Oh, and one more thing: the tests you're writing are very far away
> from the code you're testing; please consider using tests for the
> specific code, not blackbox tests. blackbox tests should really only
> be needed when you're changing code in builtins.py or the few other
> command-class containing files.
>

Done. I have added unit tests for the new functions along with the
blackbox tests.

« Back to merge proposal