Wingpanel

Merge lp:~parnold-x/wingpanel/fix_1607896 into lp:~wingpanel-devs/wingpanel/trunk

  1. fix_1607896
  2. Merge into trunk
Proposed by Djax
Status: Merged
Approved by: Danielle Foré
Approved revision: 143
Merged at revision: 143
Proposed branch: lp:~parnold-x/wingpanel/fix_1607896
Merge into: lp:~wingpanel-devs/wingpanel/trunk
Diff against target: 12 lines (+1/-2)
1 file modified
src/Services/PopoverManager.vala (+1/-2)
To merge this branch: bzr merge lp:~parnold-x/wingpanel/fix_1607896
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+301591@code.launchpad.net

Commit message

close popover on leave_notify != CrossingMode.Normal

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Confirmed that it fixed the issue and does not break drag and drop

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/PopoverManager.vala'
2--- src/Services/PopoverManager.vala 2016-06-20 21:22:50 +0000
3+++ src/Services/PopoverManager.vala 2016-07-31 15:24:10 +0000
4@@ -179,8 +179,7 @@
5 Gtk.Allocation allocation;
6 popover.get_allocation (out allocation);
7
8- if (e.mode != Gdk.CrossingMode.NORMAL
9- && (e.x < allocation.x || e.x > allocation.x + allocation.width) || (e.y < allocation.y || e.y > allocation.y + allocation.height)) {
10+ if (e.mode != Gdk.CrossingMode.NORMAL) {
11 hide_popover ();
12 }
13

Subscribers

People subscribed via source and target branches

to all changes: