Merge lp:~parnold-x/slingshot/recent-apps into lp:~elementary-pantheon/slingshot/trunk
Status: | Work in progress | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~parnold-x/slingshot/recent-apps | ||||
Merge into: | lp:~elementary-pantheon/slingshot/trunk | ||||
Diff against target: |
630 lines (+279/-33) 10 files modified
lib/synapse-core/desktop-file-service.vala (+3/-0) src/Backend/App.vala (+13/-2) src/Backend/AppSystem.vala (+32/-6) src/Backend/RelevancyService.vala (+17/-0) src/SlingshotView.vala (+28/-3) src/Widgets/CategoryView.vala (+70/-11) src/Widgets/Grid.vala (+67/-6) src/Widgets/SearchView.vala (+3/-3) src/Widgets/Sidebar.vala (+1/-1) src/Widgets/Switcher.vala (+45/-1) |
||||
To merge this branch: | bzr merge lp:~parnold-x/slingshot/recent-apps | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver | 2015-09-01 | Resubmit on 2016-02-23 | |
Daniel Fore | 2014-10-05 | Approve on 2015-09-01 | |
Sam Hewitt (community) | ux | 2014-10-05 | Approve on 2014-10-05 |
Review via email:
|
Description of the change
https:/
Add a page for most recently used applications. The page only shows up when data is available.
To also show hidden apps, etc. I used Synapse as DataSource. (By the way there are a couple of classes in synapse and slingshot that have basically the same functionality...)
If this is not wanted then we can also use the standard GMenu.Tree as source, but then we can only show apps that are also grouped in the categories in the recent used page...
Sam Hewitt (snwh) wrote : | # |
Sam Hewitt (snwh) wrote : | # |
Correction: document-
Djax (parnold-x) wrote : | # |
I thought "face-cool" is a good placeholder till someone tells me what icon I should use :)
Changed to document-
Daniel Fore (danrabbit) wrote : | # |
Can we have a tooltip for the tab button? Something like "Recently used apps"
- 457. By Cody Garver on 2014-10-05
-
No longer whitelist ibus-setup.desktop. It's bloody frightful. Whatever feature is needed from here should be added to lp:switchboard-plug-keyboard or something.
- 458. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-12
-
Launchpad automatic translations update.
- 459. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-13
-
Launchpad automatic translations update.
- 460. By Daniel Fore on 2014-10-14
-
no ellipsis
- 461. By Corentin Noël on 2014-10-15
-
* Get a consistent search entry.
* Do search asynchronously.
* Animate the view change with recent Gtk technology.
* Simplify the code regarding the addition of margins. - 462. By Corentin Noël on 2014-10-15
-
Fixes RTL positionning
- 463. By Corentin Noël on 2014-10-15
-
Switch margin_left and margin_right to margin_start and margin_end.
- 464. By Corentin Noël on 2014-10-15
-
Updated translation template.
Daniel Fore (danrabbit) wrote : | # |
Hm I get a Gtk-Critical with this branch that I don't get from trunk:
[23:25:52.955918 Gtk-Critical] gtk_container_
[23:25:52.959185 Gtk-Critical] gtk_container_
Cassidy James Blaede (cassidyjames) wrote : | # |
I feel like I should be able to scroll to the recents view; I can scroll away from it and as of now I can only get there by clicking the little icon. :P
Cassidy James Blaede (cassidyjames) wrote : | # |
Cody Garver had a genius thought: Could we make it a new view, switchable with the view switcher (View as Icons, View in Categories, View Recent)?
Cassidy James Blaede (cassidyjames) wrote : | # |
Also something I've noticed while using: it doesn't seem to add new apps right away (when they're launched). How often does it add apps to the Recent view?
Cassidy James Blaede (cassidyjames) wrote : | # |
And one last (related) item: Clearing usage data from the Security & Privacy plug does not clear the recent view, which I feel like it should. I'm not completely sure how that works. :P
- 465. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-16
-
Launchpad automatic translations update.
Djax (parnold-x) wrote : | # |
@danrabbit
fixed
@cassidyjames
scroll should be fixed (no scroll mouse here)
It adds recent apps here without any problem. But I just noticed zeitgeist only updates the most recent apps if the toggle in the privacy plug called in german "data privacy" is on???
I still get data from zeitgeist after clearing with the plug, so this is another issue. But the data is sometimes shortly kind of corrupted and then reappears?!
I will make another branch with the view switcher idea to compare.
Djax (parnold-x) wrote : | # |
Mhh, also noticed that searched apps don't update the relevancyservice from slingshot. Any thought how this should be solved? Best way would be perhaps to switch everything to the slingshot backend but this is propably a isis+1 thing.
Otherwise it will be kind of a hack I think.
Djax (parnold-x) wrote : | # |
And here a branch with the recent apps as view switcher.
Just quick n dirty as prototype so the switcher will show always and so on.
https:/
Djax (parnold-x) wrote : | # |
added recent update for searched apps but it is a bit of a hack. If anyone knows a better approach...
- 466. By Corentin Noël on 2014-10-16
-
Adapt to category bar size.
Cody Garver (codygarver) wrote : | # |
The recent apps view switcher branch does not compile
SlingshotView.vala: error: The name `scrolled_normal' does not exist in the context of `Slingshot.
- 467. By meese on 2014-10-17
-
adds a popover context menu used for showing quicklist items on right click (lp:1294917)
- 468. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-17
-
Launchpad automatic translations update.
Djax (parnold-x) wrote : | # |
@codygarver
Strange. Compiles just fine here with vala 0.24.
Cody Garver (codygarver) wrote : | # |
Djax, it happens when you merge the code with trunk e.g.
bzr branch lp:slingshot s
cd s
bzr merge lp:~parnold-x/+junk/slingshot-recent-apps-view-switcher
# compile and run
Daniel Fore (danrabbit) wrote : | # |
I don't think I like the view switcher solution. With the other two buttons, you're viewing the same data but in a different format. With the history view, you're viewing totally different data. It feels weird to me.
- 469. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-19
-
Launchpad automatic translations update.
- 470. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-20
-
Launchpad automatic translations update.
- 471. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-22
-
Launchpad automatic translations update.
- 472. By meese on 2014-10-23
-
fix quicklist icons showing up when they are not supposed to
- 473. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-24
-
Launchpad automatic translations update.
- 474. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-25
-
Launchpad automatic translations update.
- 475. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-28
-
Launchpad automatic translations update.
- 476. By Corentin Noël on 2014-10-28
-
Fixed regression triggered by rev 466, now the category view has always an item selected
- 477. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-04
-
Launchpad automatic translations update.
- 478. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-05
-
Launchpad automatic translations update.
- 479. By Djax on 2014-11-08
-
Support dragging apps in search view (lp:1008352)
- 480. By Corentin Noël on 2014-11-09
-
Simplify and fix layout size detection
- 481. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-12
-
Launchpad automatic translations update.
- 482. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-13
-
Launchpad automatic translations update.
- 483. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-14
-
Launchpad automatic translations update.
- 484. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-25
-
Launchpad automatic translations update.
- 485. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-26
-
Launchpad automatic translations update.
- 486. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-28
-
Launchpad automatic translations update.
- 487. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-29
-
Launchpad automatic translations update.
- 488. By Launchpad Translations on behalf of elementary-pantheon on 2014-11-30
-
Launchpad automatic translations update.
- 489. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-01
-
Launchpad automatic translations update.
- 490. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-06
-
Launchpad automatic translations update.
- 491. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-08
-
Launchpad automatic translations update.
- 492. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-12
-
Launchpad automatic translations update.
- 493. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-13
-
Launchpad automatic translations update.
- 494. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-23
-
Launchpad automatic translations update.
- 495. By Launchpad Translations on behalf of elementary-pantheon on 2014-12-24
-
Launchpad automatic translations update.
- 496. By Cody Garver on 2014-12-29
-
Blacklist htop.desktop
- 497. By Launchpad Translations on behalf of elementary-pantheon on 2015-01-05
-
Launchpad automatic translations update.
- 498. By Launchpad Translations on behalf of elementary-pantheon on 2015-01-09
-
Launchpad automatic translations update.
- 499. By Launchpad Translations on behalf of elementary-pantheon on 2015-01-10
-
Launchpad automatic translations update.
- 500. By Corentin Noël on 2015-02-01
-
Make use of Gtk.Popover instead of Granite.Popover.
Animates the view change from the edges.
Use real size of App Buttons (removed useless and wrong code) - 501. By Corentin Noël on 2015-02-01
-
Fixed grab loss after Drag'n'Drop.
- 502. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-03
-
Launchpad automatic translations update.
- 503. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-10
-
Launchpad automatic translations update.
- 504. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-12
-
Launchpad automatic translations update.
- 505. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-17
-
Launchpad automatic translations update.
- 506. By Rico Tzschichholz on 2015-02-17
-
appentry: Use one Gtk.Menu which gets created on demand
- 507. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-19
-
Launchpad automatic translations update.
- 508. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-20
-
Launchpad automatic translations update.
- 509. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-23
-
Launchpad automatic translations update.
- 510. By Launchpad Translations on behalf of elementary-pantheon on 2015-02-24
-
Launchpad automatic translations update.
Daniel Fore (danrabbit) wrote : | # |
Needs trunk merged.
I still feel this view should be in a list. Grid view doesn't make sense to me for something that's supposed to be in chronological order.
Djax (parnold-x) wrote : | # |
Merged the trunk and switched to list view. Search View style.
Unfortunatly no up/down keyboard support. I think to enable this a lot of changes are needed.
Daniel Fore (danrabbit) wrote : | # |
Hmm seems we have a small problem. Vertical scrolling will eventually switch pages. Any way we can stop that from happening for this recent page? If not maybe we should revert to being a grid view for now then.
I also feel like we should add "Recent" as a category in category view so that you can access this in both views.
Djax (parnold-x) wrote : | # |
Ok, now that I have a normal scroll mouse I also noticed this. With my Trackpoint it scrolls just fine the focused widgets. I enable the scrolling.
To also scroll away from the recent apps list it scrolls the page switche if the bottom is reached. But I am not sure if this is good. What do you think?
We could also restrict to 9 entries so that no scrolling is needed.
The "Recent" category as first entry, last or in alphabetic order?
Also as a list view or the normal grid?
Daniel Fore (danrabbit) wrote : | # |
> To also scroll away from the recent apps list it scrolls the page switcher if the bottom is reached. But I am not sure if this is good. What do you think?
Yep that's what I was saying that I don't think is good behavior. This shouldn't happen.
We should probably have the "Recent" category as first as it's first in the grid view
Djax (parnold-x) wrote : | # |
Yeah, I changed it to the Recent list view scrolls till the bottom and then snaps there for a moment and then when you scroll futher it scrolls away. Ok?
As list view in the category section?
- 511. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-03
-
Launchpad automatic translations update.
- 512. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-05
-
Launchpad automatic translations update.
- 513. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-10
-
Launchpad automatic translations update.
Djax (parnold-x) wrote : | # |
Could you review again?
- 514. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-21
-
Launchpad automatic translations update.
- 515. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-22
-
Launchpad automatic translations update.
- 516. By Viko Adi Rahmawan on 2015-03-24
-
* clear state flags before turning PRELIGHT on
* dont clear() on every category changes - 517. By Launchpad Translations on behalf of elementary-pantheon on 2015-03-25
-
Launchpad automatic translations update.
- 518. By Launchpad Translations on behalf of elementary-pantheon on 2015-04-06
-
Launchpad automatic translations update.
- 519. By Cody Garver on 2015-04-06
-
Release 0.8
- 520. By Launchpad Translations on behalf of elementary-pantheon on 2015-04-09
-
Launchpad automatic translations update.
- 521. By Launchpad Translations on behalf of elementary-pantheon on 2015-04-25
-
Launchpad automatic translations update.
- 522. By Launchpad Translations on behalf of elementary-pantheon on 2015-04-29
-
Launchpad automatic translations update.
- 523. By Launchpad Translations on behalf of elementary-pantheon on 2015-04-30
-
Launchpad automatic translations update.
- 524. By Rory on 2015-05-08
-
appentry: Add 'Add to/Remove from Dock' menuitem using Plank DBusManager
- 525. By Cody Garver on 2015-05-08
-
Updated translation template
- 526. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-09
-
Launchpad automatic translations update.
- 527. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-10
-
Launchpad automatic translations update.
- 528. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-14
-
Launchpad automatic translations update.
- 529. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-17
-
Launchpad automatic translations update.
- 530. By Cody Garver on 2015-05-17
-
Bump required Gtk version to 3.12
- 531. By Cody Garver on 2015-05-17
-
Updated INSTALL dependency list
- 532. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-18
-
Launchpad automatic translations update.
- 533. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-19
-
Launchpad automatic translations update.
- 534. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-26
-
Launchpad automatic translations update.
- 535. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-27
-
Launchpad automatic translations update.
- 536. By Rico Tzschichholz on 2015-05-28
-
Adapt to gtk+ binding change of Gtk.Label to fix build with valac >= 0.28
- 537. By Djax on 2015-05-29
-
Reset search highlight to first result when search entry is empty (lp:1455991)
- 538. By kay van der Zander on 2015-05-29
-
desktop-
files-plugin: fallback to possible matches if available (lp:1029612) When user types srcatch it will still show scratch
- 539. By Djax on 2015-05-29
-
Add session actions plugin (lp:1380794)
- 540. By Cody Garver on 2015-05-29
-
Updated translation template
- 541. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-29
-
Launchpad automatic translations update.
- 542. By Launchpad Translations on behalf of elementary-pantheon on 2015-05-30
-
Launchpad automatic translations update.
- 543. By Cody Garver on 2015-05-30
-
Release 0.8.1
- 544. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-01
-
Launchpad automatic translations update.
- 545. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-02
-
Launchpad automatic translations update.
- 546. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-05
-
Launchpad automatic translations update.
- 547. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-06
-
Launchpad automatic translations update.
- 548. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-07
-
Launchpad automatic translations update.
- 549. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-08
-
Launchpad automatic translations update.
- 550. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-09
-
Launchpad automatic translations update.
- 551. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-10
-
Launchpad automatic translations update.
- 552. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-14
-
Launchpad automatic translations update.
- 553. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-19
-
Launchpad automatic translations update.
- 554. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-24
-
Launchpad automatic translations update.
- 555. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-25
-
Launchpad automatic translations update.
- 556. By Launchpad Translations on behalf of elementary-pantheon on 2015-06-26
-
Launchpad automatic translations update.
- 557. By Launchpad Translations on behalf of elementary-pantheon on 2015-07-06
-
Launchpad automatic translations update.
- 558. By Launchpad Translations on behalf of elementary-pantheon on 2015-07-13
-
Launchpad automatic translations update.
- 559. By Launchpad Translations on behalf of elementary-pantheon on 2015-07-28
-
Launchpad automatic translations update.
- 560. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-07
-
Launchpad automatic translations update.
- 561. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-09
-
Launchpad automatic translations update.
- 562. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-14
-
Launchpad automatic translations update.
- 563. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-20
-
Launchpad automatic translations update.
- 564. By Cody Garver on 2015-08-20
-
Release 0.8.1.1
- 565. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-28
-
Launchpad automatic translations update.
- 566. By Launchpad Translations on behalf of elementary-pantheon on 2015-08-30
-
Launchpad automatic translations update.
- 567. By Djax on 2015-09-01
-
add recent apps category
Rico Tzschichholz (ricotz) wrote : | # |
*Reuse* results aka cache results in local *properly typed* fields to avoid refs/copies.
E.g. "Synapse.
All well and good, but perhaps instead of referring to "face-cool" refer to "document- recent- symbolic" which would be the appropriate icon –the hourglass is a from a non-default theme. :)