GTG

Merge lp:~parinporecha/gtg/more_patches into lp:~gtg/gtg/old-trunk

Proposed by Parin Porecha
Status: Merged
Merged at revision: 1274
Proposed branch: lp:~parinporecha/gtg/more_patches
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 25 lines (+3/-1)
2 files modified
CHANGELOG (+1/-0)
GTG/gtk/browser/simple_color_selector.py (+2/-1)
To merge this branch: bzr merge lp:~parinporecha/gtg/more_patches
Reviewer Review Type Date Requested Status
Izidor Matušov code, running Approve
Review via email: mp+143050@code.launchpad.net

Description of the change

This is a patch for the Bug #1079143 ( Adding the same custom color in tag editor multiple times raises an Exception ).

To post a comment you must log in.
lp:~parinporecha/gtg/more_patches updated
1275. By Parin Porecha

updated patch, removed set function, added simpler way

Revision history for this message
Izidor Matušov (izidor) wrote :

Thank you for your contribution!

review: Approve (code, running)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGELOG'
2--- CHANGELOG 2013-01-11 15:14:38 +0000
3+++ CHANGELOG 2013-01-13 20:52:19 +0000
4@@ -10,6 +10,7 @@
5 * Russian localization of help by DmDr
6 * Fix for bug #1096622: Damaged image in the help, by Parin Porecha
7 * Fix for bug #1095390: Quick Add bar incorrectly parses tags, by Parin Porecha
8+ * Fix for bug #1079143: Adding the same custom color in tag editor multiple times raises an Exception, by Parin Porecha
9
10 2012-11-06 Getting Things GNOME! 0.3
11 * Hide tasks with due date someday, #931376
12
13=== modified file 'GTG/gtk/browser/simple_color_selector.py'
14--- GTG/gtk/browser/simple_color_selector.py 2012-12-09 12:18:39 +0000
15+++ GTG/gtk/browser/simple_color_selector.py 2013-01-13 20:52:19 +0000
16@@ -303,7 +303,8 @@
17
18 def add_custom_color(self, col):
19 """Add a color to the palette, at the first position"""
20- self.custom_colors.insert(0, col)
21+ if col not in self.custom_colors:
22+ self.custom_colors.insert(0, col)
23 if len(self.custom_colors) > self.width:
24 self.custom_colors.pop()
25 self.__build_custom_palette()

Subscribers

People subscribed via source and target branches

to status/vote changes: