Merge ~paride/utah/+git/utah:xenial-fixes into utah:master

Proposed by Paride Legovini
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: dda9371692777ab0b0b705ecd07a00f8c0b5ec04
Merged at revision: c2af2d554dd51bdcaf6ef63a76cc558f15cdee3c
Proposed branch: ~paride/utah/+git/utah:xenial-fixes
Merge into: utah:master
Diff against target: 34 lines (+8/-2)
2 files modified
debian/utah.postinst (+6/-1)
utah/provisioning/vm.py (+2/-1)
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Review via email: mp+370004@code.launchpad.net

Commit message

Allow UTAH to run on Xenial again

Changes:
 - utah.postinst: support both the libvirt and libvirtd groups
 - add workaround for lp#1548499

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

sure

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/utah.postinst b/debian/utah.postinst
2index c307cc1..8636fb7 100644
3--- a/debian/utah.postinst
4+++ b/debian/utah.postinst
5@@ -56,9 +56,14 @@ EOD
6 [ -z "$SERVER_USER" ] && SERVER_USER=utah
7 [ -z "$SERVER_NAME" ] && SERVER_NAME="UTAH"
8 [ -z "$SERVER_GROUP" ] && SERVER_GROUP=utah
9- [ -z "$SERVER_GROUPS" ] && SERVER_GROUPS="libvirt,kvm"
10 [ -z "$SSH_DIR" ] && SSH_DIR=~utah/.ssh
11
12+ if [ -z "$SERVER_GROUPS" ]; then
13+ SERVER_GROUPS="kvm"
14+ getent group libvirtd >/dev/null && SERVER_GROUPS="$SERVER_GROUPS,libvirtd"
15+ getent group libvirt >/dev/null && SERVER_GROUPS="$SERVER_GROUPS,libvirt"
16+ fi
17+
18 if ! getent group | grep -q "^$SERVER_GROUP:"
19 then
20 addgroup --quiet --system $SERVER_GROUP 2>/dev/null || true
21diff --git a/utah/provisioning/vm.py b/utah/provisioning/vm.py
22index e9fb01e..f543eed 100644
23--- a/utah/provisioning/vm.py
24+++ b/utah/provisioning/vm.py
25@@ -415,7 +415,8 @@ class CustomVM(CustomInstallMixin, SSHMixin, LibvirtVM):
26 serial.set('type', 'file')
27 source = ElementTree.Element('source')
28 source.set('path', self.syslog)
29- source.set('append', 'on')
30+ # TODO: reintegrate this when the required qemu version lands
31+ # source.set('append', 'on') # lp#1548499
32 serial.append(source)
33 target = ElementTree.Element('target')
34 target.set('port', '0')

Subscribers

People subscribed via source and target branches