Merge ~paride/ubuntu/+source/postfix:lp1906970-hirsute into ubuntu/+source/postfix:ubuntu/hirsute-devel

Proposed by Paride Legovini
Status: Approved
Approved by: Sergio Durigan Junior
Approved revision: 511eb40b838096406663c059bc6b7e54e36a7111
Proposed branch: ~paride/ubuntu/+source/postfix:lp1906970-hirsute
Merge into: ubuntu/+source/postfix:ubuntu/hirsute-devel
Diff against target: 42 lines (+10/-2)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/postfix.postinst (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+407022@code.launchpad.net

Commit message

Hirsute SRU for LP: #1906970, same as https://code.launchpad.net/~paride/ubuntu/+source/postfix/+git/postfix/+merge/406805 but done against Hirsute.

Test PPA: https://launchpad.net/~paride/+archive/ubuntu/postfix-lp1906970

Test case: see [Test Plan] in the SRU bug description.

Autopkgtest summary (virt-server: lxd):

postfix PASS

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Paride.

This MP has the same problem with the package version as the Focal one.

I left further comments about the SRU template on the Focal MP. When you address them and fix the version on this MP, it should be good for upload.

Thanks.

review: Needs Fixing
511eb40... by Paride Legovini

update-maintainer

Revision history for this message
Paride Legovini (paride) wrote :

Thanks Sergio, I fixed the version string and updated the PPA as done for the Focal SRU [1].

[1] https://code.launchpad.net/~paride/ubuntu/+source/postfix/+git/postfix/+merge/407021

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thank you, Paride.

Sponsored:

$ dput postfix_3.5.6-1ubuntu0.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/postfix/postfix_3.5.6-1ubuntu0.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/postfix/postfix_3.5.6-1ubuntu0.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading postfix_3.5.6-1ubuntu0.1.dsc: done.
  Uploading postfix_3.5.6-1ubuntu0.1.debian.tar.xz: done.
  Uploading postfix_3.5.6-1ubuntu0.1_source.buildinfo: done.
  Uploading postfix_3.5.6-1ubuntu0.1_source.changes: done.
Successfully uploaded packages.

review: Approve

Unmerged commits

511eb40... by Paride Legovini

update-maintainer

ff4b922... by Paride Legovini

Update d/changelog for 3.5.6-1ubuntu0.1

eb9bfdf... by Paride Legovini

d/postfix.postinst: tolerate search domain with a leading dot

Search domain with a leading dot cause postfix.postinst to fail because
it constructs a 'myhostname' with a duplicate dot (see #991950).

The glibc resolver tolerates such domains and strips the leading dot
from the search domain [1]. This change makes postfix.postinst do the
same.

This same fix has been proposed for inclusion in Debian [2].

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=resolv/res_query.c;h=ebbe5a6a4ed86abe3fccd4a134bfcf6f613c9bbb;hb=HEAD#l411
[2] https://salsa.debian.org/postfix-team/postfix-dev/-/merge_requests/12

Closes: #991950, LP: #1906970

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 2a161f5..b4ced17 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+postfix (3.5.6-1ubuntu0.1) hirsute; urgency=medium
7+
8+ * d/postfix.postinst: tolerate search domain with a leading dot
9+ (LP: #1906970)
10+
11+ -- Paride Legovini <paride@ubuntu.com> Thu, 12 Aug 2021 14:39:06 +0200
12+
13 postfix (3.5.6-1) unstable; urgency=medium
14
15 [Dominic Raferd]
16diff --git a/debian/control b/debian/control
17index 5e9a483..3288242 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: postfix
22 Section: mail
23 Priority: optional
24-Maintainer: LaMont Jones <lamont@debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: LaMont Jones <lamont@debian.org>
27 Uploaders: Scott Kitterman <scott@kitterman.com>
28 Standards-Version: 4.5.0
29 Homepage: http://www.postfix.org
30diff --git a/debian/postfix.postinst b/debian/postfix.postinst
31index dc28f3c..9ba7eac 100644
32--- a/debian/postfix.postinst
33+++ b/debian/postfix.postinst
34@@ -49,7 +49,7 @@ myfqdn() {
35 if [ $myhostname = ${myhostname%.*} ]; then
36 if [ -f /etc/resolv.conf ]; then
37 # The resolver uses the last one found, and ignores the rest
38- mydom=$(sed -n 's/^search[[:space:]]*\([^[:space:]]*\).*/\1/p;s/^domain[[:space:]]*\([^[:space:]]*\).*/\1/p' /etc/resolv.conf | tail -1)
39+ mydom=$(sed -n 's/^search[[:space:]]*\.*\([^[:space:]]*\).*/\1/p;s/^domain[[:space:]]*\.*\([^[:space:]]*\).*/\1/p' /etc/resolv.conf | tail -1)
40 myhostname="$myhostname${mydom:+.$mydom}"
41 else
42 myhostname="$myhostname.UNKNOWN"

Subscribers

People subscribed via source and target branches