Merge ~paride/ubuntu/+source/postfix:lp1906970-focal into ubuntu/+source/postfix:ubuntu/focal-devel
Proposed by
Paride Legovini
Status: | Approved | ||||
---|---|---|---|---|---|
Approved by: | Sergio Durigan Junior | ||||
Approved revision: | 4f7a0878a299e33f184b8676cfdb477755ca2708 | ||||
Proposed branch: | ~paride/ubuntu/+source/postfix:lp1906970-focal | ||||
Merge into: | ubuntu/+source/postfix:ubuntu/focal-devel | ||||
Diff against target: |
28 lines (+8/-1) 2 files modified
debian/changelog (+7/-0) debian/postfix.postinst (+1/-1) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Durigan Junior (community) | Approve | ||
Canonical Server Core Reviewers | Pending | ||
Review via email:
|
This proposal supersedes a proposal from 2021-08-12.
Commit message
Focal SRU for LP: #1906970, same as https:/
Test PPA: https:/
Test case: see [Test Plan] in the SRU bug description.
Autopkgtest summary (virt-server: lxd):
postfix PASS
To post a comment you must log in.
Thanks for the MP, Paride.
There's a small nit with the package version; I'm leaving a comment with instructions on how to fix it.
The change itself LGTM (I reviewed the Impish MP, and this is the same change as was proposed there).
I also reviewed the SRU template on the bug and I have a few comments about it:
- Typo in the first line: s/cinf/conf/
- Duplicated text: "Test PPA"
- We're now using "[Where problems could occur]" instead of "[Regression Potential]".
- I tend to agree with your conclusion that the regression potential is negligible, but I also understand that the SRU team might frown upon this sentence. I think it's a good idea to mention that there is a very small potential for problems especially on Bionic because we could be rebuilding the package using newer versions of its dependencies. This is obviously a very rare and unlikely scenario to happen, but at least you're showing that you're considering every corner case :-). WDYT?
Aside from my comments above, the MP looks fine and should be ready for upload once the version nit is fixed.
Thanks again!