Merge ~paride/ubuntu/+source/at:lp1464051-HIRSUTE into ubuntu/+source/at:ubuntu/devel

Proposed by Paride Legovini
Status: Merged
Merged at revision: 3ce6638b24c6ba6539ed1665917a1e05ca663d6d
Proposed branch: ~paride/ubuntu/+source/at:lp1464051-HIRSUTE
Merge into: ubuntu/+source/at:ubuntu/devel
Diff against target: 54 lines (+35/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/03-do-not-drop-seconds.patch (+27/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Ubuntu Server Developers Pending
Review via email: mp+395372@code.launchpad.net

Commit message

Fixes LP: #1464051 - Low priority but very easy fix.
Test PPA: https://launchpad.net/~paride/+archive/ubuntu/atd-test

Test case:

# Buggy result:
$ at -t 201506101624.05
warning: commands will be executed using /bin/sh
at> echo hi
at> <EOT>
job 1 at Wed Jun 10 16:24:00 2015

# Expected result:
$ at -t 201506101624.05
warning: commands will be executed using /bin/sh
at> echo hi
at> <EOT>
job 1 at Wed Jun 10 16:24:05 2015

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I can review this one.

Revision history for this message
Paride Legovini (paride) wrote :

The e97122b commit message isn't in "changelog format", but it's in "git-buildpackage" format, so to generate the changelog I just did

  gbp dch --since ubuntu/devel

and that's is.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

LGTM, thanks.

$ git push pkg upload/3.1.23-1.1ubuntu2
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 8 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (11/11), 1.80 KiB | 615.00 KiB/s, done.
Total 11 (delta 5), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/at
 * [new tag] upload/3.1.23-1.1ubuntu2 -> upload/3.1.23-1.1ubuntu2

$ dput ubuntu at_3.1.23-1.1ubuntu2_source.changes
Checking signature on .changes
gpg: /home/sergio/work/at/at_3.1.23-1.1ubuntu2_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/at/at_3.1.23-1.1ubuntu2.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading at_3.1.23-1.1ubuntu2.dsc: done.
  Uploading at_3.1.23-1.1ubuntu2.debian.tar.xz: done.
  Uploading at_3.1.23-1.1ubuntu2_amd64.buildinfo: done.
  Uploading at_3.1.23-1.1ubuntu2_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 77d355e..09ff2a6 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+at (3.1.23-1.1ubuntu2) hirsute; urgency=medium
7+
8+ * d/patches: add 03-do-not-drop-seconds.patch (cherry-pick).
9+ When calculating time for the job, do not drop seconds. (LP: #1464051)
10+
11+ -- Paride Legovini <paride.legovini@canonical.com> Tue, 15 Dec 2020 12:01:14 +0100
12+
13 at (3.1.23-1.1ubuntu1) hirsute; urgency=medium
14
15 * Merge with Debian unstable. Remaining changes:
16diff --git a/debian/patches/03-do-not-drop-seconds.patch b/debian/patches/03-do-not-drop-seconds.patch
17new file mode 100644
18index 0000000..1aaa8a3
19--- /dev/null
20+++ b/debian/patches/03-do-not-drop-seconds.patch
21@@ -0,0 +1,27 @@
22+From 15ee22de9dfd67d9c97404302623a9d45ce887a2 Mon Sep 17 00:00:00 2001
23+From: Jose M Calhariz <calhariz@debian.org>
24+Date: Wed, 17 Jul 2019 02:18:15 +0100
25+Subject: [PATCH] when calculating time for the job, do not drop seconds
26+Origin: upstream, https://salsa.debian.org/debian/at/-/commit/15ee22de9dfd67d9c97404302623a9d45ce887a2
27+Bug-Debian: https://bugs.debian.org/792040
28+
29+---
30+ at.c | 2 --
31+ 1 file changed, 2 deletions(-)
32+
33+diff --git a/at.c b/at.c
34+index 2136e0b..48884ec 100644
35+--- a/at.c
36++++ b/at.c
37+@@ -860,8 +860,6 @@ main(int argc, char **argv)
38+ fprintf(stderr, "invalid date format: %s\n", optarg);
39+ exit(EXIT_FAILURE);
40+ }
41+- /* drop seconds */
42+- timer -= timer % 60;
43+ break;
44+
45+ default:
46+--
47+GitLab
48+
49diff --git a/debian/patches/series b/debian/patches/series
50index e69de29..1dacf3a 100644
51--- a/debian/patches/series
52+++ b/debian/patches/series
53@@ -0,0 +1 @@
54+03-do-not-drop-seconds.patch

Subscribers

People subscribed via source and target branches