Merge ~paride/ubuntu-seeds/+git/platform:seed-probert into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:groovy

[Paride Legovini]

[Paride Legovini (paride)]

Prior to this change germinate pulled in:

probert-common | probert | probert-storage | Ubuntu Developers <email address hidden> | 17064 | 118

probert-storage | probert | curtin | Ubuntu Developers <email address hidden> | 13864 | 63

with this change:

probert | probert | Ubuntu.Groovy supported-installer-server seed | Ubuntu Developers <email address hidden> | 1768 | 12

probert-common | probert | probert-storage | Ubuntu Developers <email address hidden> | 17064 | 118

probert-storage | probert | probert | Ubuntu Developers <email address hidden> | 13864 | 63

with:

? Unknown dependency probert-network by probert

which has to be included in main (change-override).

[Paride Legovini (paride)]

First time I touch the seeds, so pedantic reviews are appreciated :)

[Christian Ehrhardt  (paelzer)]

I was looking into the underlying case which is #1890301 and agree with the approach in general.

I was doing a pre/post germinate run as well:
+probert | probert | Ubuntu.Groovy supported-installer-server seed
Ok we want that (more clear than the current off i386 only dependency)
+? Unknown dependency probert-network by probert on arch amd64
This is due tot he component mismatch and running main-only.

Running the same pre/post with universe enabled:
Now we get the expected component mismatch:
  10 +probert | probert | Ubuntu.Groovy supported-installer-server seed | Ubuntu Developers <<email address hidden>
  11 +probert-common | probert | probert-network | Ubuntu Developers <<email address hidden>
  12 +probert-network | probert | probert | Ubuntu Developers <<email address hidden>
  13 +probert-storage | probert | probert | Ubuntu Developers

Addition of the new supported-installer-server - ack
It is listed in the right places.

I see no warnings about this new seed:
 117 +* Downloading file:///home/paelzer/work/seeds/ubuntu.groovy/supported-installer-server
 118 +* Downloading file:///home/paelzer/work/seeds/ubuntu.groovy/languages/supported-installer-server
 119 +* Downloading file:///home/paelzer/work/seeds/platform.groovy/supported-installer-server
works fine and is used
We get all the auxiliary files for supported-installer-server that I'd expect like e.g. supported-installer-server.depends

As a side effect probert source will move from the general "supported.sources" to "supported-installer-server.sources" which is fine I think

The probert meta package LGTM as start for all subpackages and the source.
Much better than missing it like now but still having it in the installer snap build.

Overall LGTM +1

review: Approve

diff --git a/STRUCTURE b/STRUCTURE
index 2924088..22cc1c0 100644
--- a/STRUCTURE
+++ b/STRUCTURE
@@ -26,10 +26,11 @@ supported-hardware-desktop: standard
 supported-hardware-server: standard
 supported-installer-common: standard
 supported-installer-desktop: standard
+supported-installer-server: standard
 supported-network-common: standard
 supported-network-client: standard
 supported-sysadmin-common: standard
 supported-sysadmin-server: standard
-supported-server: supported-misc-servers supported-hardware-common supported-hardware-server supported-installer-common supported-network-common supported-sysadmin-common supported-sysadmin-server build-essential supported-development-common supported-kernel-common supported-cloud supported-maas supported-landscape supported-openstack
+supported-server: supported-misc-servers supported-hardware-common supported-hardware-server supported-installer-common supported-installer-server supported-network-common supported-sysadmin-common supported-sysadmin-server build-essential supported-development-common supported-kernel-common supported-cloud supported-maas supported-landscape supported-openstack
 supported-desktop: supported-hardware-desktop supported-installer-desktop supported-hardware-common supported-installer-common supported-network-common supported-network-client supported-sysadmin-common build-essential supported-development-common supported-development-desktop supported-kernel-common supported-kernel-desktop
 supported-common: supported-server supported-desktop 
diff --git a/supported-installer-server b/supported-installer-server
new file mode 100644
index 0000000..ef12be9
--- /dev/null
+++ b/supported-installer-server
@@ -0,0 +1,3 @@
+= Installer =
+
+ * probert # needed by subiquity