Merge ~paride/britney/+git/hints-ubuntu:qiime into ~ubuntu-release/britney/+git/hints-ubuntu:devel

Proposed by Paride Legovini
Status: Merged
Merged at revision: 1f4260fac36b731a32aad80d7789fa891d42bb71
Proposed branch: ~paride/britney/+git/hints-ubuntu:qiime
Merge into: ~ubuntu-release/britney/+git/hints-ubuntu:devel
Diff against target: 12 lines (+4/-0)
1 file modified
ubuntu-release (+4/-0)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Brian Murray Needs Information
Review via email: mp+427073@code.launchpad.net

Description of the change

Tests assume a 64 bit system. From https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic/kinetic/armhf/q/qiime/20220715_111517_68c97@/log.gz

======================================================================
FAIL: test_roundtrip_int (qiime2.core.tests.test_missing.TestError)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.nRGPjU/autopkgtest_tmp/qiime2/core/tests/test_missing.py", line 89, in test_roundtrip_int
    self.check_roundtrip(42, int)
  File "/tmp/autopkgtest.nRGPjU/autopkgtest_tmp/qiime2/core/tests/test_missing.py", line 26, in check_roundtrip
    self.assertEqual(encoded.dtype, dtype)
AssertionError: dtype('int64') != <class 'int'>

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Is there a bug number in Launchpad which we can refer to in the hint? Additionally, if the broken tests are causing the package to fail to migrate (it appears on update-excuses) the bug should be tagged update-excuse for future travelers.

review: Needs Information
Revision history for this message
Paride Legovini (paride) wrote :

MP updated with pointer to update-excuse bug.

Revision history for this message
Steve Langasek (vorlon) wrote :

Confirmed that this is a new test and the test is buggy, not necessarily the code. It's suboptimal that we are regressing test coverage on armhf as a result (by no longer being able to check the status of the many other tests that do pass) but we have a bug to track the issue.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/ubuntu-release b/ubuntu-release
index 67e253c..fada4b7 100644
--- a/ubuntu-release
+++ b/ubuntu-release
@@ -23,3 +23,7 @@ force-badtest exim4/4.95-4ubuntu2/ppc64el
2323
24# test needs a perl module on i38624# test needs a perl module on i386
25force-badtest libclass-dbi-sweet-perl/0.11-2/i38625force-badtest libclass-dbi-sweet-perl/0.11-2/i386
26
27# tests known broken on 32bit archs (LP: #1982117).
28# i386 never passed (no need to hint).
29force-badtest qiime/2022.2.1-2/armhf

Subscribers

People subscribed via source and target branches