Auto Upgrade Testing Specifications

Merge ~paride/auto-upgrade-testing-specifications:check-var-crash-empty into auto-upgrade-testing-specifications:main

  1. Git
  2. lp:~paride/auto-upgrade-testing-specifications
  3. check-var-crash-empty
  4. Merge into main
Proposed by Paride Legovini
Status: Merged
Merged at revision: d97ed3ac0fa2deb4da405e5ded312ea25aa34590
Proposed branch: ~paride/auto-upgrade-testing-specifications:check-var-crash-empty
Merge into: auto-upgrade-testing-specifications:main
Diff against target: 273 lines (+39/-24)
25 files modified
profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml (+1/-1)
tests/check-var-crash-empty (+15/-0)
Reviewer Review Type Date Requested Status
Tim Andersson Approve
Brian Murray Approve
Canonical Platform QA Team Pending
Review via email: mp+440420@code.launchpad.net

Commit message

Check that /var/crash is empty after upgrading.

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

Tested locally by running:

auto-upgrade-testing --config /path/to/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml --provision

Revision history for this message
Brian Murray (brian-murray) wrote :

I wonder how useful finding out about a crash during an upgrade from Xenial to Bionic will be but we can always remove the test later! Thanks for doing this.

review: Approve
Revision history for this message
Paride Legovini (paride) :
Revision history for this message
Tim Andersson (andersson123) :
review: Approve
Revision history for this message
Tim Andersson (andersson123) :
review: Approve
Revision history for this message
Tim Andersson (andersson123) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
2index a62638c..e084a89 100644
3--- a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
4+++ b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
5@@ -14,4 +14,4 @@
6 - "rcS-workaround"
7
8 post_upgrade_tests:
9- - "null"
10+ - "check-var-crash-empty"
11diff --git a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
12index 6336e85..e609927 100644
13--- a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
14+++ b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
15@@ -16,6 +16,6 @@
16 - "rcS-workaround"
17
18 post_upgrade_tests:
19- - "null"
20+ - "check-var-crash-empty"
21
22 run_system_tests: true
23diff --git a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
24index edb5965..1c3850a 100644
25--- a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
26+++ b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
27@@ -14,4 +14,4 @@
28 - "null"
29
30 post_upgrade_tests:
31- - "null"
32+ - "check-var-crash-empty"
33diff --git a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
34index b9c4dad..675a623 100644
35--- a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
36+++ b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
37@@ -16,6 +16,6 @@
38 - "check-ubuntu-desktop"
39
40 post_upgrade_tests:
41- - "null"
42+ - "check-var-crash-empty"
43
44 run_system_tests: true
45diff --git a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
46index 7b4a088..61f5810 100644
47--- a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
48+++ b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
49@@ -16,4 +16,4 @@
50 - "check-kubuntu-desktop"
51
52 post_upgrade_tests:
53- - "null"
54+ - "check-var-crash-empty"
55diff --git a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
56index 9c1d6fb..8085669 100644
57--- a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
58+++ b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
59@@ -16,4 +16,4 @@
60 - "check-lubuntu-desktop"
61
62 post_upgrade_tests:
63- - "null"
64+ - "check-var-crash-empty"
65diff --git a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
66index f815451..b882c6c 100644
67--- a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
68+++ b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
69@@ -16,4 +16,4 @@
70 - "check-ubuntu-mate-desktop"
71
72 post_upgrade_tests:
73- - "null"
74+ - "check-var-crash-empty"
75diff --git a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
76index 8ffbd25..141be2f 100644
77--- a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
78+++ b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
79@@ -16,4 +16,4 @@
80 - "check-xubuntu-desktop"
81
82 post_upgrade_tests:
83- - "null"
84+ - "check-var-crash-empty"
85diff --git a/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
86index 0e28b6c..8b5d30b 100644
87--- a/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
88+++ b/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
89@@ -14,4 +14,4 @@
90 - "null"
91
92 post_upgrade_tests:
93- - "null"
94+ - "check-var-crash-empty"
95diff --git a/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
96index 40057fb..f6ccb7c 100644
97--- a/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
98+++ b/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
99@@ -16,6 +16,6 @@
100 - "check-ubuntu-desktop"
101
102 post_upgrade_tests:
103- - "null"
104+ - "check-var-crash-empty"
105
106 run_system_tests: true
107diff --git a/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
108index c1753ec..7a0b349 100644
109--- a/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
110+++ b/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
111@@ -16,4 +16,4 @@
112 - "check-kubuntu-desktop"
113
114 post_upgrade_tests:
115- - "null"
116+ - "check-var-crash-empty"
117diff --git a/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
118index c56eff2..e7ac21d 100644
119--- a/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
120+++ b/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
121@@ -16,4 +16,4 @@
122 - "check-lubuntu-desktop"
123
124 post_upgrade_tests:
125- - "null"
126+ - "check-var-crash-empty"
127diff --git a/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
128index 0279d48..e964479 100644
129--- a/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
130+++ b/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
131@@ -16,4 +16,4 @@
132 - "check-ubuntu-mate-desktop"
133
134 post_upgrade_tests:
135- - "null"
136+ - "check-var-crash-empty"
137diff --git a/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
138index 3411c97..1333af6 100644
139--- a/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
140+++ b/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
141@@ -16,4 +16,4 @@
142 - "check-xubuntu-desktop"
143
144 post_upgrade_tests:
145- - "null"
146+ - "check-var-crash-empty"
147diff --git a/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
148index 16eeeb0..6554ea5 100644
149--- a/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
150+++ b/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
151@@ -14,4 +14,4 @@
152 - "null"
153
154 post_upgrade_tests:
155- - "null"
156+ - "check-var-crash-empty"
157diff --git a/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
158index 17fd5bd..8b456e6 100644
159--- a/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
160+++ b/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
161@@ -16,6 +16,6 @@
162 - "check-ubuntu-desktop"
163
164 post_upgrade_tests:
165- - "null"
166+ - "check-var-crash-empty"
167
168 run_system_tests: true
169diff --git a/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
170index 68f8c86..03e4833 100644
171--- a/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
172+++ b/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
173@@ -16,4 +16,4 @@
174 - "check-kubuntu-desktop"
175
176 post_upgrade_tests:
177- - "null"
178+ - "check-var-crash-empty"
179diff --git a/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
180index 76f2803..35ee6b6 100644
181--- a/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
182+++ b/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
183@@ -16,4 +16,4 @@
184 - "check-lubuntu-desktop"
185
186 post_upgrade_tests:
187- - "null"
188+ - "check-var-crash-empty"
189diff --git a/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
190index fab263e..01e7d99 100644
191--- a/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
192+++ b/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
193@@ -16,4 +16,4 @@
194 - "check-ubuntu-mate-desktop"
195
196 post_upgrade_tests:
197- - "null"
198+ - "check-var-crash-empty"
199diff --git a/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
200index db8b4b5..b55de23 100644
201--- a/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
202+++ b/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
203@@ -16,4 +16,4 @@
204 - "check-xubuntu-desktop"
205
206 post_upgrade_tests:
207- - "null"
208+ - "check-var-crash-empty"
209diff --git a/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml b/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
210index ec09d91..3fdfc07 100644
211--- a/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
212+++ b/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
213@@ -14,4 +14,4 @@
214 - "rcS-workaround"
215
216 post_upgrade_tests:
217- - "null"
218+ - "check-var-crash-empty"
219diff --git a/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml b/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
220index ed355ec..9b3e2f1 100644
221--- a/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
222+++ b/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
223@@ -14,4 +14,4 @@
224 - "rcS-workaround"
225
226 post_upgrade_tests:
227- - "null"
228+ - "check-var-crash-empty"
229diff --git a/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml b/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
230index 96b572b..0e1d18c 100644
231--- a/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
232+++ b/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
233@@ -16,6 +16,6 @@
234 - "rcS-workaround"
235
236 post_upgrade_tests:
237- - "null"
238+ - "check-var-crash-empty"
239
240 run_system_tests: true
241diff --git a/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml b/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
242index dc4dc3a..6e11443 100644
243--- a/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
244+++ b/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
245@@ -16,6 +16,6 @@
246 - "rcS-workaround"
247
248 post_upgrade_tests:
249- - "null"
250+ - "check-var-crash-empty"
251
252 run_system_tests: true
253diff --git a/tests/check-var-crash-empty b/tests/check-var-crash-empty
254new file mode 100755
255index 0000000..c7dfa3e
256--- /dev/null
257+++ b/tests/check-var-crash-empty
258@@ -0,0 +1,15 @@
259+#!/bin/sh
260+
261+set -e
262+
263+crashdir=/var/crash
264+
265+echo "Checking for (absence of) crash files in $crashdir."
266+
267+if find "$crashdir" -maxdepth 0 ! -empty -exec false {} +; then
268+ echo "PASS: $crashdir is empty (good)"
269+else
270+ echo "FAIL: $crashdir is not empty. Crash files sorted by creation time:"
271+ ls -gGh -tr --time=creation --full-time "$crashdir"
272+ exit 1
273+fi

Subscribers

People subscribed via source and target branches

to all changes: