Merge ~pappacena/twisted:pr1478-backport into ~launchpad/twisted:Twisted-20.3.0+lp3

Proposed by Thiago F. Pappacena
Status: Needs review
Proposed branch: ~pappacena/twisted:pr1478-backport
Merge into: ~launchpad/twisted:Twisted-20.3.0+lp3
Diff against target: 19 lines (+2/-2)
1 file modified
src/twisted/internet/process.py (+2/-2)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+395999@code.launchpad.net

Commit message

Removing dict.itervalues call from process for py3 compatibility (upstream PR https://github.com/twisted/twisted/pull/1478).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Unmerged commits

d66d8a8... by Thiago F. Pappacena

Removing dict.itervalues call from process for py3 compatibility

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/twisted/internet/process.py b/src/twisted/internet/process.py
2index de94cb8..b188e2b 100644
3--- a/src/twisted/internet/process.py
4+++ b/src/twisted/internet/process.py
5@@ -846,13 +846,13 @@ class Process(_BaseProcess):
6
7
8 def pauseProducing(self):
9- for p in self.pipes.itervalues():
10+ for p in self.pipes.values():
11 if isinstance(p, ProcessReader):
12 p.stopReading()
13
14
15 def resumeProducing(self):
16- for p in self.pipes.itervalues():
17+ for p in self.pipes.values():
18 if isinstance(p, ProcessReader):
19 p.startReading()
20

Subscribers

People subscribed via source and target branches