Merge ~pappacena/twisted:py3-cgiscript into ~pappacena/twisted:conch-ssh-multiplex-session-env

Proposed by Thiago F. Pappacena
Status: Superseded
Proposed branch: ~pappacena/twisted:py3-cgiscript
Merge into: ~pappacena/twisted:conch-ssh-multiplex-session-env
Diff against target: 13 lines (+1/-1)
1 file modified
src/twisted/web/twcgi.py (+1/-1)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena Pending
Review via email: mp+395390@code.launchpad.net

Commit message

Backporting fix for bug mixing str and bytes on CGIScript resource

To post a comment you must log in.

Unmerged commits

a8b12a6... by Thiago F. Pappacena

Fixing problem mixing str and bytes on CGIScript resource

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/twisted/web/twcgi.py b/src/twisted/web/twcgi.py
2index 1c92960..9e3f406 100644
3--- a/src/twisted/web/twcgi.py
4+++ b/src/twisted/web/twcgi.py
5@@ -109,7 +109,7 @@ class CGIScript(resource.Resource):
6 qargs = []
7 else:
8 qs = env['QUERY_STRING'] = request.uri[qindex+1:]
9- if '=' in qs:
10+ if b"=" in qs:
11 qargs = []
12 else:
13 qargs = [urllib.unquote(x) for x in qs.split('+')]

Subscribers

People subscribed via source and target branches

to all changes: