Merge ~pappacena/turnip:popen-close-streams into turnip:master

[Thiago F. Pappacena]

Closing Popen std streams to avoid warnings on python3

[Colin Watson (cjwatson)]

review: Needs Fixing

[Thiago F. Pappacena (pappacena)]

Pushed the requested changes, cjwatson.

[Colin Watson (cjwatson)]

review: Approve

diff --git a/turnip/api/tests/test_helpers.py b/turnip/api/tests/test_helpers.py
index a6035b4..d1a288c 100644
--- a/turnip/api/tests/test_helpers.py
+++ b/turnip/api/tests/test_helpers.py
@@ -6,7 +6,7 @@ import fnmatch
 import itertools
 import logging
 import os
-from subprocess import PIPE, Popen, CalledProcessError
+from subprocess import PIPE, Popen, CalledProcessError, STDOUT
 import uuid
 
 from pygit2 import (
@@ -112,12 +112,13 @@ class RepoFactory(object):
         cmd_line = ['git', '-C', self.repo_path]
         cmd_line += self._get_cmd_line_auth_params()
         cmd_line += ['tag', '-m', tag_message, tag_name, oid.hex]
-        subproc = Popen(cmd_line, stderr=PIPE, stdout=PIPE)
-        retcode = subproc.wait()
+        subproc = Popen(cmd_line, stdout=PIPE, stderr=STDOUT)
+        out, err = subproc.communicate()
+        retcode = subproc.returncode
         if retcode:
             log.error(
                 "Command %s finished with error code %s. stdout/stderr:\n%s",
-                cmd_line, retcode, subproc.stderr.read())
+                cmd_line, retcode, out)
             raise CalledProcessError(retcode, cmd_line)
 
     def makeSignature(self, name, email, encoding='utf-8'):