Merge ~pappacena/turnip:py3-strings-compat into turnip:master
Proposed by
Thiago F. Pappacena
Status: | Merged |
---|---|
Approved by: | Thiago F. Pappacena |
Approved revision: | 75d004fdfe0011fc49dca6ffbb8505af1de9a1ad |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~pappacena/turnip:py3-strings-compat |
Merge into: | turnip:master |
Diff against target: |
259 lines (+80/-29) 5 files modified
turnip/api/store.py (+11/-9) turnip/api/tests/test_api.py (+10/-13) turnip/api/tests/test_helpers.py (+30/-7) turnip/tests/__init__.py (+13/-0) turnip/tests/logging.py (+16/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+380451@code.launchpad.net |
Commit message
Making some strings compatible both with python2 and python3
Description of the change
This MP should only be merged once we have the new dependencies in place.
It reduces the total amount of failing tests on python3:
From (failures=10, errors=28) to (failures=6, errors=21)
To post a comment you must log in.
I'd particularly like to see my comments about get_refs disentangled, but should be fine after that.