turnip

Merge ~pappacena/turnip/+git/turnip-dependencies:reverting-pygit-dep-version into ~canonical-launchpad-branches/turnip/+git/dependencies:master

  1. Git
  2. lp:~pappacena/turnip/+git/turnip-dependencies
  3. reverting-pygit-dep-version
  4. Merge into master
Proposed by Thiago F. Pappacena
Status: Merged
Approved by: Thiago F. Pappacena
Approved revision: aca979f2a571bf0b91d9d1e33ae98b8c4e501240
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pappacena/turnip/+git/turnip-dependencies:reverting-pygit-dep-version
Merge into: ~canonical-launchpad-branches/turnip/+git/dependencies:master
Diff against target: 4 lines (+0/-0)
0 files modified
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Colin Watson (community) Approve
Review via email: mp+380545@code.launchpad.net

Commit message

Downgrading pycparser to 2.17, since pygit requires pycparser<2.18. This dependency is only checked at runtime when running `make run-api`, so it ended up being merged to master without CI failure.

On the code branch, we'll add `pip check` as part of the `make check` procedure, so this doesn't happen again.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/pycparser-2.17.tar.gz b/pycparser-2.17.tar.gz
2new file mode 100644
3index 0000000..76182b2
4Binary files /dev/null and b/pycparser-2.17.tar.gz differ

Subscribers

People subscribed via source and target branches