Launchpad itself

~pappacena/launchpad:fix-distroseries-diff-comment

Git
lp:~pappacena/launchpad
fix-distroseries-diff-comment

Last commit made on 2021-05-24

Get this branch:: git clone -b fix-distroseries-diff-comment https://git.launchpad.net/~pappacena/launchpad

Only Thiago F. Pappacena can upload to this branch. If you are Thiago F. Pappacena please log in for upload directions.

Branch merges

Merged into launchpad:master

Colin Watson (community): Approve on 2021-05-24

Branch information

Name:: fix-distroseries-diff-comment

Repository:: lp:~pappacena/launchpad

Recent commits

e3a5def... by Thiago F. Pappacena on 2021-05-24

Fixing distroseries diff comment display

112f452... by Thiago F. Pappacena on 2021-05-24

Adding editing option to code review comments

Merged from https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402850

30919b7... by Thiago F. Pappacena on 2021-05-24

Adding editing option to bug comments

Merged from https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402604

65698f6... by Thiago F. Pappacena on 2021-05-24

Javascript component to edit messages, and its first usage in QuestionMessage view

Merged from https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402522

5ddbd7e... by Tom Wardill on 2021-05-24

Add LAUNCHPAD_BUILD_ARCH as a default BUILD_ARG

Merged from https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/403194

b243d95... by Colin Watson on 2021-05-24

Discard previous interaction in endRequest

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/403193

d42eb15... by Tom Wardill on 2021-05-24

Add LAUNCHPAD_BUILD_ARCH as a default BUILD_ARG

616079b... by Colin Watson on 2021-05-24

format-imports

554ff40... by Colin Watson on 2021-05-24

Discard previous interaction in endRequest

Zope's `BrowserPublication.endRequest` leaves a reference to the
previous interaction lying around in thread-local storage just in case
somebody might want to call `restoreInteraction` later. However, this
significantly complicates cyclic garbage collection and memory leak
analysis, because it means that objects referenced by a request can
never be garbage-collected immediately after the request finishes, but
at best only somewhat later.

There are cases in Launchpad where we do use `restoreInteraction`, but
none of them are after the end of publishing a request, so simplify
matters by discarding the previous interaction.

f2c0c64... by Thiago F. Pappacena on 2021-05-21

Make sure that only owners can edit CodeReviewComment by requiring a more specific permission

Merged from https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/403146

»