Merge ~pappacena/launchpad:snap-pillar into launchpad:master
Proposed by
Thiago F. Pappacena
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Thiago F. Pappacena | ||||
Approved revision: | c7955b9825801193bb479a9d3528abff9a661144 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~pappacena/launchpad:snap-pillar | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
372 lines (+119/-14) 5 files modified
database/schema/security.cfg (+3/-0) lib/lp/snappy/interfaces/snap.py (+33/-4) lib/lp/snappy/model/snap.py (+58/-5) lib/lp/snappy/tests/test_snap.py (+16/-2) lib/lp/testing/factory.py (+9/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+397458@code.launchpad.net |
Commit message
Adding Snap.project to be the (optional) pillar of snaps
Description of the change
This adds a project to be the optional pillar of Snaps (mandatory for private Snaps). Once we create the UI to set this, we should start validating and only allowing private Snaps that belongs to a given pillar (so we can use the pillar's sharing options to control Snap's privacy).
Database patch is available here: https:/
To post a comment you must log in.
Pushed the requested change.
I've also removed the XXX comment about validating (project + private) attributes at model level. It would break old snaps if we've added that validation in the future.