Merge ~pappacena/launchpad:hot-gitrepo-status-column into launchpad:master

[Thiago F. Pappacena]

Hot patch to add index, default value and NOT NULL constraint to GitRepository.status.

This database patch should be applied "hot", with CONCURRENTLY on the index creation, after the MP https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/385199 is landed.

a1de430... by Thiago F. Pappacena on 2020-06-08

Setting default value for GitRepo.status and moving index creation to the end

[Colin Watson (cjwatson)]

review: Approve (db)

[Thiago F. Pappacena (pappacena)]

cjwatson, added a comment about the index creation.

07033ba... by Thiago F. Pappacena on 2020-06-12

Changing index creation for gitrepository.date_created / status

[Thiago F. Pappacena (pappacena)]

Pushed the changes to turn GitRepository.status index into GitRepository.date_created index, filtered by status = 1 (creating).

[Thiago F. Pappacena (pappacena)]

Merging it to master now that it was run in production.

diff --git a/database/schema/patch-2210-17-1.sql b/database/schema/patch-2210-17-1.sql
new file mode 100644
index 0000000..f1813af
--- /dev/null
+++ b/database/schema/patch-2210-17-1.sql
@@ -0,0 +1,17 @@
+-- Copyright 2020 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+-- Status "2" is GitRepositoryStatus.AVAILABLE
+UPDATE GitRepository SET status = 2 WHERE status IS NULL;
+
+ALTER TABLE GitRepository
+    ALTER COLUMN status SET NOT NULL;
+
+CREATE INDEX gitrepository__date_created__status__idx
+    ON GitRepository (date_created)
+    -- 1 == CREATING
+    WHERE status = 1;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 17, 1);