Merge ~pappacena/launchpad:not-valid-on-gitrepo-constraint-migration into launchpad:db-devel

Proposed by Thiago F. Pappacena
Status: Merged
Approved by: Thiago F. Pappacena
Approved revision: 9f65077498a6822e1d5e16584bd69eddead1efb4
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pappacena/launchpad:not-valid-on-gitrepo-constraint-migration
Merge into: launchpad:db-devel
Diff against target: 21 lines (+4/-2)
1 file modified
database/schema/patch-2210-08-8.sql (+4/-2)
Reviewer Review Type Date Requested Status
William Grant db Approve
Review via email: mp+385005@code.launchpad.net

Commit message

Moving CHECK constraint validation to a hot patch, instead of doing it in the "fast downtime" workflow.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/database/schema/patch-2210-08-8.sql b/database/schema/patch-2210-08-8.sql
2index dffbaac..5a20873 100644
3--- a/database/schema/patch-2210-08-8.sql
4+++ b/database/schema/patch-2210-08-8.sql
5@@ -35,12 +35,14 @@ ALTER TABLE GitRepository
6 -- OCI project
7 (project IS NULL AND distribution IS NULL AND sourcepackagename IS NULL AND oci_project IS NOT NULL AND ociprojectname IS NULL) OR
8 -- Personal
9- (project IS NULL AND distribution IS NULL AND sourcepackagename IS NULL AND oci_project IS NULL)),
10+ (project IS NULL AND distribution IS NULL AND sourcepackagename IS NULL AND oci_project IS NULL))
11+ NOT VALID,
12 DROP CONSTRAINT default_implies_target,
13 ADD CONSTRAINT default_implies_target CHECK (
14 project IS NOT NULL
15 OR distribution IS NOT NULL
16 OR oci_project IS NOT NULL
17- OR (NOT owner_default AND NOT target_default));
18+ OR (NOT owner_default AND NOT target_default))
19+ NOT VALID;
20
21 INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 8, 8);