Merge ~pappacena/launchpad:fix-ocirecipebuild-api-export into launchpad:master

[Thiago F. Pappacena]

Disabling the export of IOCIRecipeBuildRequest.builds on the API.

We need to discuss how this OCIRecipeBuilds will be exported on the webservice, and the exporting of IOCIRecipeBuildRequest.builds is breaking the app server startup.

[Thiago F. Pappacena (pappacena)]

Self-approving to fix the build.

I'll open a follow-up MP with a proper fix.

review: Approve

diff --git a/lib/lp/oci/interfaces/ocirecipe.py b/lib/lp/oci/interfaces/ocirecipe.py
index c469886..ea14d04 100644
--- a/lib/lp/oci/interfaces/ocirecipe.py
+++ b/lib/lp/oci/interfaces/ocirecipe.py
@@ -164,11 +164,11 @@ class IOCIRecipeBuildRequest(Interface):
     error_message = exported(TextLine(
         title=_("Error message"), required=False, readonly=True))
 
-    builds = exported(CollectionField(
+    builds = CollectionField(
         title=_("Builds produced by this request"),
         # Really IOCIRecipeBuild, patched in lp.oci.interfaces.webservice.
         value_type=Reference(schema=Interface),
-        required=True, readonly=True))
+        required=True, readonly=True)
 
 
 class IOCIRecipeView(Interface):
diff --git a/lib/lp/oci/tests/test_ocirecipe.py b/lib/lp/oci/tests/test_ocirecipe.py
index 965096b..42e854a 100644
--- a/lib/lp/oci/tests/test_ocirecipe.py
+++ b/lib/lp/oci/tests/test_ocirecipe.py
@@ -977,17 +977,4 @@ class TestOCIRecipeAsyncWebservice(TestCaseWithFactory):
                 date_requested=Equals(fmt_date(build_request.date_requested)),
                 date_finished=Equals(fmt_date(build_request.date_finished)),
                 error_message=Equals(build_request.error_message),
-                builds_collection_link=Equals(build_request_url + '/builds')
             )))
-
-        builds = self.webservice.get(
-            ws_build_request["builds_collection_link"]).jsonBody()["entries"]
-        with person_logged_in(self.person):
-            self.assertThat(builds, MatchesSetwise(*[
-                ContainsDict({
-                    "buildstate": Equals("Needs building"),
-                    "title": Equals(
-                        "%s build of %s" % (
-                            arch_series.processor.name, api_url(oci_recipe)))
-                })
-                for arch_series in distro_arch_series]))