Merge ~pappacena/launchpad:renaming-archive-signing-key into launchpad:master
- Git
- lp:~pappacena/launchpad
- renaming-archive-signing-key
- Merge into master
Proposed by
Thiago F. Pappacena
Status: | Merged |
---|---|
Approved by: | Thiago F. Pappacena |
Approved revision: | 3127948bdb7e32e06bbcc2113345439b6ef8bba3 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~pappacena/launchpad:renaming-archive-signing-key |
Merge into: | launchpad:master |
Diff against target: |
590 lines (+77/-75) 18 files modified
lib/lp/archivepublisher/archivegpgsigningkey.py (+11/-11) lib/lp/archivepublisher/configure.zcml (+5/-5) lib/lp/archivepublisher/customupload.py (+1/-1) lib/lp/archivepublisher/interfaces/archivegpgsigningkey.py (+4/-4) lib/lp/archivepublisher/publishing.py (+1/-1) lib/lp/archivepublisher/tests/archive-signing.txt (+12/-12) lib/lp/archivepublisher/tests/test_archivegpgsigningkey.py (+4/-4) lib/lp/archivepublisher/tests/test_customupload.py (+5/-4) lib/lp/archivepublisher/tests/test_publishdistro.py (+5/-5) lib/lp/archivepublisher/tests/test_publisher.py (+3/-3) lib/lp/archivepublisher/tests/test_signing.py (+5/-4) lib/lp/code/model/tests/test_recipebuilder.py (+3/-3) lib/lp/snappy/tests/test_snapbuildbehaviour.py (+3/-3) lib/lp/soyuz/adapters/tests/test_archivedependencies.py (+3/-3) lib/lp/soyuz/scripts/ppakeygenerator.py (+3/-3) lib/lp/soyuz/tests/test_archive.py (+3/-3) lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py (+3/-3) lib/lp/soyuz/tests/test_livefsbuildbehaviour.py (+3/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+378826@code.launchpad.net |
Commit message
Renaming (I)ArchiveSigni
Description of the change
Currently, the class named ArchiveSigningKey only deals with GPG signing, wereas package signing mechanisms are done by another class.
As a path to migrate the signing to a new service, we are planning to have a database entity named ArchiveSigningKey. So, to make the code more readable, we are changing the current ArchiveSigningKey to a more specific name.
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) : | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | diff --git a/lib/lp/archivepublisher/archivesigningkey.py b/lib/lp/archivepublisher/archivegpgsigningkey.py |
2 | similarity index 94% |
3 | rename from lib/lp/archivepublisher/archivesigningkey.py |
4 | rename to lib/lp/archivepublisher/archivegpgsigningkey.py |
5 | index cb8737b..2b14365 100644 |
6 | --- a/lib/lp/archivepublisher/archivesigningkey.py |
7 | +++ b/lib/lp/archivepublisher/archivegpgsigningkey.py |
8 | @@ -1,12 +1,12 @@ |
9 | # Copyright 2009-2018 Canonical Ltd. This software is licensed under the |
10 | # GNU Affero General Public License version 3 (see the file LICENSE). |
11 | |
12 | -"""ArchiveSigningKey implementation.""" |
13 | +"""ArchiveGPGSigningKey implementation.""" |
14 | |
15 | __metaclass__ = type |
16 | |
17 | __all__ = [ |
18 | - 'ArchiveSigningKey', |
19 | + 'ArchiveGPGSigningKey', |
20 | 'SignableArchive', |
21 | 'SigningMode', |
22 | ] |
23 | @@ -29,9 +29,9 @@ from zope.security.proxy import ( |
24 | |
25 | from lp.app.interfaces.launchpad import ILaunchpadCelebrities |
26 | from lp.archivepublisher.config import getPubConfig |
27 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
28 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
29 | CannotSignArchive, |
30 | - IArchiveSigningKey, |
31 | + IArchiveGPGSigningKey, |
32 | ISignableArchive, |
33 | ) |
34 | from lp.archivepublisher.run_parts import ( |
35 | @@ -176,18 +176,18 @@ class SignableArchive: |
36 | [(path, "%s.gpg" % path, SigningMode.DETACHED, suite)], log=log) |
37 | |
38 | |
39 | -@implementer(IArchiveSigningKey) |
40 | -class ArchiveSigningKey(SignableArchive): |
41 | +@implementer(IArchiveGPGSigningKey) |
42 | +class ArchiveGPGSigningKey(SignableArchive): |
43 | """`IArchive` adapter for manipulating its GPG key.""" |
44 | |
45 | def getPathForSecretKey(self, key): |
46 | - """See `IArchiveSigningKey`.""" |
47 | + """See `IArchiveGPGSigningKey`.""" |
48 | return os.path.join( |
49 | config.personalpackagearchive.signing_keys_root, |
50 | "%s.gpg" % key.fingerprint) |
51 | |
52 | def exportSecretKey(self, key): |
53 | - """See `IArchiveSigningKey`.""" |
54 | + """See `IArchiveGPGSigningKey`.""" |
55 | assert key.secret, "Only secret keys should be exported." |
56 | export_path = self.getPathForSecretKey(key) |
57 | |
58 | @@ -198,7 +198,7 @@ class ArchiveSigningKey(SignableArchive): |
59 | export_file.write(key.export()) |
60 | |
61 | def generateSigningKey(self): |
62 | - """See `IArchiveSigningKey`.""" |
63 | + """See `IArchiveGPGSigningKey`.""" |
64 | assert self.archive.signing_key is None, ( |
65 | "Cannot override signing_keys.") |
66 | |
67 | @@ -208,7 +208,7 @@ class ArchiveSigningKey(SignableArchive): |
68 | default_ppa = self.archive.owner.archive |
69 | if self.archive != default_ppa: |
70 | if default_ppa.signing_key is None: |
71 | - IArchiveSigningKey(default_ppa).generateSigningKey() |
72 | + IArchiveGPGSigningKey(default_ppa).generateSigningKey() |
73 | key = default_ppa.signing_key |
74 | self.archive.signing_key_owner = key.owner |
75 | self.archive.signing_key_fingerprint = key.fingerprint |
76 | @@ -221,7 +221,7 @@ class ArchiveSigningKey(SignableArchive): |
77 | self._setupSigningKey(secret_key) |
78 | |
79 | def setSigningKey(self, key_path, async_keyserver=False): |
80 | - """See `IArchiveSigningKey`.""" |
81 | + """See `IArchiveGPGSigningKey`.""" |
82 | assert self.archive.signing_key is None, ( |
83 | "Cannot override signing_keys.") |
84 | assert os.path.exists(key_path), ( |
85 | diff --git a/lib/lp/archivepublisher/configure.zcml b/lib/lp/archivepublisher/configure.zcml |
86 | index 99bdcb4..f52d4ff 100644 |
87 | --- a/lib/lp/archivepublisher/configure.zcml |
88 | +++ b/lib/lp/archivepublisher/configure.zcml |
89 | @@ -10,15 +10,15 @@ |
90 | xmlns:xmlrpc="http://namespaces.zope.org/xmlrpc" |
91 | i18n_domain="launchpad"> |
92 | |
93 | - <!-- ArchiveSigningKey --> |
94 | - <class class="lp.archivepublisher.archivesigningkey.ArchiveSigningKey"> |
95 | - <allow interface="lp.archivepublisher.interfaces.archivesigningkey.IArchiveSigningKey"/> |
96 | + <!-- ArchiveGPGSigningKey --> |
97 | + <class class="lp.archivepublisher.archivegpgsigningkey.ArchiveGPGSigningKey"> |
98 | + <allow interface="lp.archivepublisher.interfaces.archivegpgsigningkey.IArchiveGPGSigningKey"/> |
99 | </class> |
100 | |
101 | <adapter |
102 | for="lp.soyuz.interfaces.archive.IArchive" |
103 | - provides="lp.archivepublisher.interfaces.archivesigningkey.IArchiveSigningKey" |
104 | - factory="lp.archivepublisher.archivesigningkey.ArchiveSigningKey" |
105 | + provides="lp.archivepublisher.interfaces.archivegpgsigningkey.IArchiveGPGSigningKey" |
106 | + factory="lp.archivepublisher.archivegpgsigningkey.ArchiveGPGSigningKey" |
107 | /> |
108 | |
109 | <!-- PublisherConfig --> |
110 | diff --git a/lib/lp/archivepublisher/customupload.py b/lib/lp/archivepublisher/customupload.py |
111 | index 7db20cb..0c6a2c9 100644 |
112 | --- a/lib/lp/archivepublisher/customupload.py |
113 | +++ b/lib/lp/archivepublisher/customupload.py |
114 | @@ -27,7 +27,7 @@ from lp.archivepublisher.debversion import ( |
115 | Version as make_version, |
116 | VersionError, |
117 | ) |
118 | -from lp.archivepublisher.interfaces.archivesigningkey import ISignableArchive |
119 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ISignableArchive |
120 | from lp.services.librarian.utils import copy_and_close |
121 | from lp.soyuz.interfaces.queue import ( |
122 | CustomUploadError, |
123 | diff --git a/lib/lp/archivepublisher/interfaces/archivesigningkey.py b/lib/lp/archivepublisher/interfaces/archivegpgsigningkey.py |
124 | similarity index 95% |
125 | rename from lib/lp/archivepublisher/interfaces/archivesigningkey.py |
126 | rename to lib/lp/archivepublisher/interfaces/archivegpgsigningkey.py |
127 | index 01e4a50..85d3bfb 100644 |
128 | --- a/lib/lp/archivepublisher/interfaces/archivesigningkey.py |
129 | +++ b/lib/lp/archivepublisher/interfaces/archivegpgsigningkey.py |
130 | @@ -1,13 +1,13 @@ |
131 | # Copyright 2009-2018 Canonical Ltd. This software is licensed under the |
132 | # GNU Affero General Public License version 3 (see the file LICENSE). |
133 | |
134 | -"""ArchiveSigningKey interface.""" |
135 | +"""ArchiveGPGSigningKey interface.""" |
136 | |
137 | __metaclass__ = type |
138 | |
139 | __all__ = [ |
140 | 'CannotSignArchive', |
141 | - 'IArchiveSigningKey', |
142 | + 'IArchiveGPGSigningKey', |
143 | 'ISignableArchive', |
144 | ] |
145 | |
146 | @@ -67,8 +67,8 @@ class ISignableArchive(Interface): |
147 | """ |
148 | |
149 | |
150 | -class IArchiveSigningKey(ISignableArchive): |
151 | - """`ArchiveSigningKey` interface. |
152 | +class IArchiveGPGSigningKey(ISignableArchive): |
153 | + """`ArchiveGPGSigningKey` interface. |
154 | |
155 | `IArchive` adapter for operations using its 'signing_key'. |
156 | |
157 | diff --git a/lib/lp/archivepublisher/publishing.py b/lib/lp/archivepublisher/publishing.py |
158 | index 523c51c..3365c68 100644 |
159 | --- a/lib/lp/archivepublisher/publishing.py |
160 | +++ b/lib/lp/archivepublisher/publishing.py |
161 | @@ -63,7 +63,7 @@ from lp.archivepublisher.indices import ( |
162 | build_source_stanza_fields, |
163 | build_translations_stanza_fields, |
164 | ) |
165 | -from lp.archivepublisher.interfaces.archivesigningkey import ISignableArchive |
166 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ISignableArchive |
167 | from lp.archivepublisher.model.ftparchive import FTPArchiveHandler |
168 | from lp.archivepublisher.utils import ( |
169 | get_ppa_reference, |
170 | diff --git a/lib/lp/archivepublisher/tests/archive-signing.txt b/lib/lp/archivepublisher/tests/archive-signing.txt |
171 | index 853398e..f2dfca9 100644 |
172 | --- a/lib/lp/archivepublisher/tests/archive-signing.txt |
173 | +++ b/lib/lp/archivepublisher/tests/archive-signing.txt |
174 | @@ -127,10 +127,10 @@ location defined by the system configuration. |
175 | /var/tmp/ppa-signing-keys.test |
176 | |
177 | In order to manipulate 'signing_keys' securily the target archive |
178 | -object has to be adapted to `IArchiveSigningKey`. |
179 | +object has to be adapted to `IArchiveGPGSigningKey`. |
180 | |
181 | - >>> from lp.archivepublisher.interfaces.archivesigningkey import ( |
182 | - ... IArchiveSigningKey) |
183 | + >>> from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
184 | + ... IArchiveGPGSigningKey) |
185 | |
186 | We will adapt Celso's PPA after modifing its distribution to allow |
187 | proper publish configuration based on the sampledata. |
188 | @@ -142,15 +142,15 @@ proper publish configuration based on the sampledata. |
189 | >>> cprov.archive.distribution = getUtility( |
190 | ... IDistributionSet).getByName('ubuntutest') |
191 | |
192 | - >>> archive_signing_key = IArchiveSigningKey(cprov.archive) |
193 | + >>> archive_signing_key = IArchiveGPGSigningKey(cprov.archive) |
194 | |
195 | -Once adapted `IArchiveSigningKey` is properly implemented. |
196 | +Once adapted `IArchiveGPGSigningKey` is properly implemented. |
197 | |
198 | >>> from zope.interface.verify import verifyObject |
199 | - >>> verifyObject(IArchiveSigningKey, archive_signing_key) |
200 | + >>> verifyObject(IArchiveGPGSigningKey, archive_signing_key) |
201 | True |
202 | |
203 | -`IArchiveSigningKey` object contain the corresponding IArchive |
204 | +`IArchiveGPGSigningKey` object contain the corresponding IArchive |
205 | object. |
206 | |
207 | >>> print archive_signing_key.archive.displayname |
208 | @@ -185,7 +185,7 @@ in the expected path. |
209 | ... archive_signing_key.getPathForSecretKey(mock_key)).read() |
210 | Secret True |
211 | |
212 | -At this point we can use the `IArchiveSigningKey` to generate and |
213 | +At this point we can use the `IArchiveGPGSigningKey` to generate and |
214 | assign a real signing_key, although this procedure depends heavily on |
215 | machine entropy and ends up being very slow in our test machine. |
216 | |
217 | @@ -193,7 +193,7 @@ machine entropy and ends up being very slow in our test machine. |
218 | |
219 | We will use a pre-existing key in our tree which is virtually |
220 | identical to the one that would be generated. The key will be 'set' by |
221 | -using a method `IArchiveSigningKey` skips the key generation but uses |
222 | +using a method `IArchiveGPGSigningKey` skips the key generation but uses |
223 | exactly the same procedure for setting the signing_key information. |
224 | |
225 | >>> import os |
226 | @@ -300,7 +300,7 @@ Default PPAs are always created first and thus get their keys generated |
227 | before the named-ppa for the same owner. We submit the named-ppa to |
228 | the key generation procedure, as it would be normally in production. |
229 | |
230 | - >>> named_ppa_signing_key = IArchiveSigningKey(named_ppa) |
231 | + >>> named_ppa_signing_key = IArchiveGPGSigningKey(named_ppa) |
232 | >>> named_ppa_signing_key.generateSigningKey() |
233 | |
234 | Instead of generating a new key, the signing key from the default ppa |
235 | @@ -348,7 +348,7 @@ in the default PPA context then propagated to the named-ppa. The key is |
236 | named after the user, even if the default PPA name is something different. |
237 | |
238 | >>> cprov.display_name = "Not Celso Providelo" |
239 | - >>> named_ppa_signing_key = IArchiveSigningKey(named_ppa) |
240 | + >>> named_ppa_signing_key = IArchiveGPGSigningKey(named_ppa) |
241 | >>> named_ppa_signing_key.generateSigningKey() |
242 | Generating: Launchpad PPA for Not Celso Providelo |
243 | |
244 | @@ -366,7 +366,7 @@ Restore the original functionality of GPGHandler. |
245 | Signing PPA repository |
246 | ---------------------- |
247 | |
248 | -`IArchiveSigningKey.signRepository` can be user to sign repositories |
249 | +`IArchiveGPGSigningKey.signRepository` can be user to sign repositories |
250 | for archive which already contains a 'signing_key'. |
251 | |
252 | Celso's default PPA will uses the testing signing key. |
253 | diff --git a/lib/lp/archivepublisher/tests/test_archivesigningkey.py b/lib/lp/archivepublisher/tests/test_archivegpgsigningkey.py |
254 | similarity index 95% |
255 | rename from lib/lp/archivepublisher/tests/test_archivesigningkey.py |
256 | rename to lib/lp/archivepublisher/tests/test_archivegpgsigningkey.py |
257 | index a394823..47600b6 100644 |
258 | --- a/lib/lp/archivepublisher/tests/test_archivesigningkey.py |
259 | +++ b/lib/lp/archivepublisher/tests/test_archivegpgsigningkey.py |
260 | @@ -1,7 +1,7 @@ |
261 | # Copyright 2016-2019 Canonical Ltd. This software is licensed under the |
262 | # GNU Affero General Public License version 3 (see the file LICENSE). |
263 | |
264 | -"""Test ArchiveSigningKey.""" |
265 | +"""Test ArchiveGPGSigningKey.""" |
266 | |
267 | from __future__ import absolute_import, print_function, unicode_literals |
268 | |
269 | @@ -16,8 +16,8 @@ from twisted.internet import defer |
270 | from zope.component import getUtility |
271 | |
272 | from lp.archivepublisher.config import getPubConfig |
273 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
274 | - IArchiveSigningKey, |
275 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
276 | + IArchiveGPGSigningKey, |
277 | ISignableArchive, |
278 | ) |
279 | from lp.archivepublisher.interfaces.publisherconfig import IPublisherConfigSet |
280 | @@ -51,7 +51,7 @@ class TestSignableArchiveWithSigningKey(TestCaseWithFactory): |
281 | with InProcessKeyServerFixture() as keyserver: |
282 | yield keyserver.start() |
283 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
284 | - yield IArchiveSigningKey(self.archive).setSigningKey( |
285 | + yield IArchiveGPGSigningKey(self.archive).setSigningKey( |
286 | key_path, async_keyserver=True) |
287 | |
288 | def test_signFile_absolute_within_archive(self): |
289 | diff --git a/lib/lp/archivepublisher/tests/test_customupload.py b/lib/lp/archivepublisher/tests/test_customupload.py |
290 | index a5f8a89..43a88db 100644 |
291 | --- a/lib/lp/archivepublisher/tests/test_customupload.py |
292 | +++ b/lib/lp/archivepublisher/tests/test_customupload.py |
293 | @@ -33,8 +33,8 @@ from lp.archivepublisher.customupload import ( |
294 | CustomUploadTarballBadSymLink, |
295 | CustomUploadTarballInvalidFileType, |
296 | ) |
297 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
298 | - IArchiveSigningKey, |
299 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
300 | + IArchiveGPGSigningKey, |
301 | ) |
302 | from lp.archivepublisher.interfaces.publisherconfig import IPublisherConfigSet |
303 | from lp.archivepublisher.tests.test_run_parts import RunPartsMixin |
304 | @@ -260,7 +260,7 @@ class TestSigning(TestCaseWithFactory, RunPartsMixin): |
305 | self.assertIsNone(self.archive.signing_key) |
306 | self.useFixture(InProcessKeyServerFixture()).start() |
307 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
308 | - yield IArchiveSigningKey(self.archive).setSigningKey( |
309 | + yield IArchiveGPGSigningKey(self.archive).setSigningKey( |
310 | key_path, async_keyserver=True) |
311 | self.assertIsNotNone(self.archive.signing_key) |
312 | custom_processor = CustomUpload() |
313 | @@ -280,7 +280,8 @@ class TestSigning(TestCaseWithFactory, RunPartsMixin): |
314 | write_file(filename, b"contents") |
315 | self.assertIsNone(self.archive.signing_key) |
316 | run_parts_fixture = self.useFixture(MonkeyPatch( |
317 | - "lp.archivepublisher.archivesigningkey.run_parts", FakeMethod())) |
318 | + "lp.archivepublisher.archivegpgsigningkey.run_parts", |
319 | + FakeMethod())) |
320 | custom_processor = CustomUpload() |
321 | custom_processor.sign(self.archive, "suite", filename) |
322 | args, kwargs = run_parts_fixture.new_value.calls[0] |
323 | diff --git a/lib/lp/archivepublisher/tests/test_publishdistro.py b/lib/lp/archivepublisher/tests/test_publishdistro.py |
324 | index d81421e..3d6d699 100644 |
325 | --- a/lib/lp/archivepublisher/tests/test_publishdistro.py |
326 | +++ b/lib/lp/archivepublisher/tests/test_publishdistro.py |
327 | @@ -24,8 +24,8 @@ from zope.security.proxy import removeSecurityProxy |
328 | |
329 | from lp.app.interfaces.launchpad import ILaunchpadCelebrities |
330 | from lp.archivepublisher.config import getPubConfig |
331 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
332 | - IArchiveSigningKey, |
333 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
334 | + IArchiveGPGSigningKey, |
335 | ) |
336 | from lp.archivepublisher.interfaces.publisherconfig import IPublisherConfigSet |
337 | from lp.archivepublisher.publishing import Publisher |
338 | @@ -256,7 +256,7 @@ class TestPublishDistro(TestNativePublishingBase): |
339 | self.setUpRequireSigningKeys() |
340 | yield self.useFixture(InProcessKeyServerFixture()).start() |
341 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
342 | - yield IArchiveSigningKey(cprov.archive).setSigningKey( |
343 | + yield IArchiveGPGSigningKey(cprov.archive).setSigningKey( |
344 | key_path, async_keyserver=True) |
345 | name16.archive.signing_key_owner = cprov.archive.signing_key_owner |
346 | name16.archive.signing_key_fingerprint = ( |
347 | @@ -308,7 +308,7 @@ class TestPublishDistro(TestNativePublishingBase): |
348 | self.setUpRequireSigningKeys() |
349 | yield self.useFixture(InProcessKeyServerFixture()).start() |
350 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
351 | - yield IArchiveSigningKey(private_ppa).setSigningKey( |
352 | + yield IArchiveGPGSigningKey(private_ppa).setSigningKey( |
353 | key_path, async_keyserver=True) |
354 | |
355 | # Try a plain PPA run, to ensure the private one is NOT published. |
356 | @@ -413,7 +413,7 @@ class TestPublishDistro(TestNativePublishingBase): |
357 | self.setUpRequireSigningKeys() |
358 | yield self.useFixture(InProcessKeyServerFixture()).start() |
359 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
360 | - yield IArchiveSigningKey(archive).setSigningKey( |
361 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
362 | key_path, async_keyserver=True) |
363 | |
364 | self.layer.txn.commit() |
365 | diff --git a/lib/lp/archivepublisher/tests/test_publisher.py b/lib/lp/archivepublisher/tests/test_publisher.py |
366 | index ec60e1f..8fd5616 100644 |
367 | --- a/lib/lp/archivepublisher/tests/test_publisher.py |
368 | +++ b/lib/lp/archivepublisher/tests/test_publisher.py |
369 | @@ -67,8 +67,8 @@ from zope.security.proxy import removeSecurityProxy |
370 | |
371 | from lp.archivepublisher.config import getPubConfig |
372 | from lp.archivepublisher.diskpool import DiskPool |
373 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
374 | - IArchiveSigningKey, |
375 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
376 | + IArchiveGPGSigningKey, |
377 | ) |
378 | from lp.archivepublisher.publishing import ( |
379 | BY_HASH_STAY_OF_EXECUTION, |
380 | @@ -3211,7 +3211,7 @@ class TestPublisherRepositorySignatures( |
381 | |
382 | # Set a signing key for Celso's PPA. |
383 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
384 | - yield IArchiveSigningKey(cprov.archive).setSigningKey( |
385 | + yield IArchiveGPGSigningKey(cprov.archive).setSigningKey( |
386 | key_path, async_keyserver=True) |
387 | self.assertTrue(cprov.archive.signing_key is not None) |
388 | |
389 | diff --git a/lib/lp/archivepublisher/tests/test_signing.py b/lib/lp/archivepublisher/tests/test_signing.py |
390 | index 3966362..efe4ae6 100644 |
391 | --- a/lib/lp/archivepublisher/tests/test_signing.py |
392 | +++ b/lib/lp/archivepublisher/tests/test_signing.py |
393 | @@ -34,8 +34,8 @@ from lp.archivepublisher.customupload import ( |
394 | CustomUploadAlreadyExists, |
395 | CustomUploadBadUmask, |
396 | ) |
397 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
398 | - IArchiveSigningKey, |
399 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
400 | + IArchiveGPGSigningKey, |
401 | ) |
402 | from lp.archivepublisher.interfaces.publisherconfig import IPublisherConfigSet |
403 | from lp.archivepublisher.signing import ( |
404 | @@ -212,7 +212,7 @@ class TestSigningHelpers(TestCaseWithFactory): |
405 | with InProcessKeyServerFixture() as keyserver: |
406 | yield keyserver.start() |
407 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
408 | - yield IArchiveSigningKey(self.archive).setSigningKey( |
409 | + yield IArchiveGPGSigningKey(self.archive).setSigningKey( |
410 | key_path, async_keyserver=True) |
411 | |
412 | def setUpUefiKeys(self, create=True, series=None): |
413 | @@ -1356,7 +1356,8 @@ class TestSigning(RunPartsMixin, TestSigningHelpers): |
414 | # run_parts is called. |
415 | self.enableRunParts(distribution_name=self.distro.name) |
416 | run_parts_fixture = self.useFixture(MonkeyPatch( |
417 | - "lp.archivepublisher.archivesigningkey.run_parts", FakeMethod())) |
418 | + "lp.archivepublisher.archivegpgsigningkey.run_parts", |
419 | + FakeMethod())) |
420 | self.setUpUefiKeys() |
421 | self.setUpKmodKeys() |
422 | self.setUpOpalKeys() |
423 | diff --git a/lib/lp/code/model/tests/test_recipebuilder.py b/lib/lp/code/model/tests/test_recipebuilder.py |
424 | index fd96be5..c07fce7 100644 |
425 | --- a/lib/lp/code/model/tests/test_recipebuilder.py |
426 | +++ b/lib/lp/code/model/tests/test_recipebuilder.py |
427 | @@ -19,8 +19,8 @@ from twisted.trial.unittest import TestCase as TrialTestCase |
428 | from zope.component import getUtility |
429 | from zope.security.proxy import removeSecurityProxy |
430 | |
431 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
432 | - IArchiveSigningKey, |
433 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
434 | + IArchiveGPGSigningKey, |
435 | ) |
436 | from lp.buildmaster.enums import BuildStatus |
437 | from lp.buildmaster.interactor import BuilderInteractor |
438 | @@ -347,7 +347,7 @@ class TestAsyncRecipeBuilder(TestRecipeBuilderBase): |
439 | yield self.useFixture(InProcessKeyServerFixture()).start() |
440 | archive = self.factory.makeArchive() |
441 | key_path = os.path.join(gpgkeysdir, "ppa-sample@canonical.com.sec") |
442 | - yield IArchiveSigningKey(archive).setSigningKey( |
443 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
444 | key_path, async_keyserver=True) |
445 | job = self.makeJob(archive=archive, with_builder=True) |
446 | distroarchseries = job.build.distroseries.architectures[0] |
447 | diff --git a/lib/lp/snappy/tests/test_snapbuildbehaviour.py b/lib/lp/snappy/tests/test_snapbuildbehaviour.py |
448 | index 3a506c5..b397bba 100644 |
449 | --- a/lib/lp/snappy/tests/test_snapbuildbehaviour.py |
450 | +++ b/lib/lp/snappy/tests/test_snapbuildbehaviour.py |
451 | @@ -54,8 +54,8 @@ from zope.publisher.xmlrpc import TestRequest |
452 | from zope.security.proxy import removeSecurityProxy |
453 | |
454 | from lp.app.enums import InformationType |
455 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
456 | - IArchiveSigningKey, |
457 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
458 | + IArchiveGPGSigningKey, |
459 | ) |
460 | from lp.buildmaster.enums import ( |
461 | BuildBaseImageType, |
462 | @@ -649,7 +649,7 @@ class TestAsyncSnapBuildBehaviour(TestSnapBuildBehaviourBase): |
463 | yield self.useFixture(InProcessKeyServerFixture()).start() |
464 | archive = self.factory.makeArchive() |
465 | key_path = os.path.join(gpgkeysdir, "ppa-sample@canonical.com.sec") |
466 | - yield IArchiveSigningKey(archive).setSigningKey( |
467 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
468 | key_path, async_keyserver=True) |
469 | job = self.makeJob(archive=archive) |
470 | self.factory.makeBinaryPackagePublishingHistory( |
471 | diff --git a/lib/lp/soyuz/adapters/tests/test_archivedependencies.py b/lib/lp/soyuz/adapters/tests/test_archivedependencies.py |
472 | index dbb2343..7cd3cad 100644 |
473 | --- a/lib/lp/soyuz/adapters/tests/test_archivedependencies.py |
474 | +++ b/lib/lp/soyuz/adapters/tests/test_archivedependencies.py |
475 | @@ -20,8 +20,8 @@ from twisted.internet.threads import deferToThread |
476 | from zope.component import getUtility |
477 | from zope.security.proxy import removeSecurityProxy |
478 | |
479 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
480 | - IArchiveSigningKey, |
481 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
482 | + IArchiveGPGSigningKey, |
483 | ) |
484 | from lp.registry.interfaces.distribution import IDistributionSet |
485 | from lp.registry.interfaces.pocket import PackagePublishingPocket |
486 | @@ -174,7 +174,7 @@ class TestSourcesList(TestCaseWithFactory): |
487 | archive = self.factory.makeArchive(distribution=self.ubuntu, **kwargs) |
488 | if signing_key_name is not None: |
489 | key_path = os.path.join(gpgkeysdir, "%s.sec" % signing_key_name) |
490 | - yield IArchiveSigningKey(archive).setSigningKey( |
491 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
492 | key_path, async_keyserver=True) |
493 | if publish_binary: |
494 | self.publisher.getPubBinaries( |
495 | diff --git a/lib/lp/soyuz/scripts/ppakeygenerator.py b/lib/lp/soyuz/scripts/ppakeygenerator.py |
496 | index 00bebac..c1aa3f6 100644 |
497 | --- a/lib/lp/soyuz/scripts/ppakeygenerator.py |
498 | +++ b/lib/lp/soyuz/scripts/ppakeygenerator.py |
499 | @@ -7,8 +7,8 @@ __all__ = [ |
500 | |
501 | from zope.component import getUtility |
502 | |
503 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
504 | - IArchiveSigningKey, |
505 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
506 | + IArchiveGPGSigningKey, |
507 | ) |
508 | from lp.services.scripts.base import ( |
509 | LaunchpadCronScript, |
510 | @@ -32,7 +32,7 @@ class PPAKeyGenerator(LaunchpadCronScript): |
511 | self.logger.info( |
512 | "Generating signing key for %s (%s)" % |
513 | (archive.reference, archive.displayname)) |
514 | - archive_signing_key = IArchiveSigningKey(archive) |
515 | + archive_signing_key = IArchiveGPGSigningKey(archive) |
516 | archive_signing_key.generateSigningKey() |
517 | self.logger.info("Key %s" % archive.signing_key.fingerprint) |
518 | |
519 | diff --git a/lib/lp/soyuz/tests/test_archive.py b/lib/lp/soyuz/tests/test_archive.py |
520 | index 20b7b2f..8660e70 100644 |
521 | --- a/lib/lp/soyuz/tests/test_archive.py |
522 | +++ b/lib/lp/soyuz/tests/test_archive.py |
523 | @@ -37,8 +37,8 @@ from zope.security.proxy import removeSecurityProxy |
524 | |
525 | from lp.app.errors import NotFoundError |
526 | from lp.app.interfaces.launchpad import ILaunchpadCelebrities |
527 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
528 | - IArchiveSigningKey, |
529 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
530 | + IArchiveGPGSigningKey, |
531 | ) |
532 | from lp.buildmaster.enums import ( |
533 | BuildQueueStatus, |
534 | @@ -1827,7 +1827,7 @@ class TestArchiveDependencies(TestCaseWithFactory): |
535 | with InProcessKeyServerFixture() as keyserver: |
536 | yield keyserver.start() |
537 | key_path = os.path.join(gpgkeysdir, 'ppa-sample@canonical.com.sec') |
538 | - yield IArchiveSigningKey(p3a).setSigningKey( |
539 | + yield IArchiveGPGSigningKey(p3a).setSigningKey( |
540 | key_path, async_keyserver=True) |
541 | dependency = self.factory.makeArchive( |
542 | name='dependency', private=True, owner=p3a.owner) |
543 | diff --git a/lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py b/lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py |
544 | index 61e4847..cc08bc5 100644 |
545 | --- a/lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py |
546 | +++ b/lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py |
547 | @@ -22,8 +22,8 @@ from zope.component import getUtility |
548 | from zope.security.proxy import removeSecurityProxy |
549 | |
550 | from lp.archivepublisher.diskpool import poolify |
551 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
552 | - IArchiveSigningKey, |
553 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
554 | + IArchiveGPGSigningKey, |
555 | ) |
556 | from lp.buildmaster.enums import ( |
557 | BuilderCleanStatus, |
558 | @@ -354,7 +354,7 @@ class TestBinaryBuildPackageBehaviour(TestCaseWithFactory): |
559 | archive = self.factory.makeArchive() |
560 | builder = self.factory.makeBuilder() |
561 | key_path = os.path.join(gpgkeysdir, "ppa-sample@canonical.com.sec") |
562 | - yield IArchiveSigningKey(archive).setSigningKey( |
563 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
564 | key_path, async_keyserver=True) |
565 | build = self.factory.makeBinaryPackageBuild(archive=archive) |
566 | self.factory.makeBinaryPackagePublishingHistory( |
567 | diff --git a/lib/lp/soyuz/tests/test_livefsbuildbehaviour.py b/lib/lp/soyuz/tests/test_livefsbuildbehaviour.py |
568 | index 29e697e..95e9694 100644 |
569 | --- a/lib/lp/soyuz/tests/test_livefsbuildbehaviour.py |
570 | +++ b/lib/lp/soyuz/tests/test_livefsbuildbehaviour.py |
571 | @@ -20,8 +20,8 @@ from twisted.trial.unittest import TestCase as TrialTestCase |
572 | from zope.component import getUtility |
573 | from zope.security.proxy import Proxy |
574 | |
575 | -from lp.archivepublisher.interfaces.archivesigningkey import ( |
576 | - IArchiveSigningKey, |
577 | +from lp.archivepublisher.interfaces.archivegpgsigningkey import ( |
578 | + IArchiveGPGSigningKey, |
579 | ) |
580 | from lp.buildmaster.enums import ( |
581 | BuildBaseImageType, |
582 | @@ -247,7 +247,7 @@ class TestAsyncLiveFSBuildBehaviour(TestLiveFSBuildBehaviourBase): |
583 | yield self.useFixture(InProcessKeyServerFixture()).start() |
584 | archive = self.factory.makeArchive() |
585 | key_path = os.path.join(gpgkeysdir, "ppa-sample@canonical.com.sec") |
586 | - yield IArchiveSigningKey(archive).setSigningKey( |
587 | + yield IArchiveGPGSigningKey(archive).setSigningKey( |
588 | key_path, async_keyserver=True) |
589 | job = self.makeJob(archive=archive, with_builder=True) |
590 | self.factory.makeBinaryPackagePublishingHistory( |