Merge lp:~paolorotolo/ubuntu-clock-app/fix-for-1202364 into lp:ubuntu-clock-app/saucy

Proposed by Paolo Rotolo
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 150
Merged at revision: 148
Proposed branch: lp:~paolorotolo/ubuntu-clock-app/fix-for-1202364
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 70 lines (+6/-6)
4 files modified
alarm/AlarmPage.qml (+1/-1)
clock/ClockPage.qml (+1/-1)
clock/WorldClock.qml (+2/-2)
timer/TimerPage.qml (+2/-2)
To merge this branch: bzr merge lp:~paolorotolo/ubuntu-clock-app/fix-for-1202364
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+175928@code.launchpad.net

Commit message

 - Stopwatch: Added lap and clear icons.
 - Added the grey version of the clear icon for the toolbar.
 - Timer: added white space between the text label and the reset icon.

Description of the change

- Stopwatch: Added lap and clear icons.
- Added the grey version of the clear icon for the toolbar.
- Timer: added white space between the text label and the reset icon.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

lgtm! Merging :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'alarm/AlarmPage.qml'
2--- alarm/AlarmPage.qml 2013-07-14 12:40:59 +0000
3+++ alarm/AlarmPage.qml 2013-07-19 19:18:28 +0000
4@@ -773,7 +773,7 @@
5
6 back: ToolbarButton {
7 text: "Back";
8- iconSource: Qt.resolvedUrl("../images/reset_icon.png")
9+ iconSource: Qt.resolvedUrl("../images/back_icon.png")
10 visible: !addAlarm.visible;
11 onTriggered: {
12 circleMinutes.state = "NORMAL";
13
14=== modified file 'clock/ClockPage.qml'
15--- clock/ClockPage.qml 2013-07-16 18:25:18 +0000
16+++ clock/ClockPage.qml 2013-07-19 19:18:28 +0000
17@@ -296,7 +296,7 @@
18
19 back: ToolbarButton {
20 text: "Back";
21- iconSource: Qt.resolvedUrl("../images/reset_icon.png")
22+ iconSource: Qt.resolvedUrl("../images/back_icon.png")
23 visible: !addCity.visible;
24 onTriggered: {
25 clockPage.state = "NORMAL";
26
27=== modified file 'clock/WorldClock.qml'
28--- clock/WorldClock.qml 2013-07-16 18:25:18 +0000
29+++ clock/WorldClock.qml 2013-07-19 19:18:28 +0000
30@@ -78,8 +78,8 @@
31 hasClearButton: true
32 placeholderText: i18n.tr("Search");
33 primaryItem: Image {
34- height: parent.height/1.5
35- width: height
36+ height: parent.height/1.4
37+ width: parent.height/1.45
38 source: Qt.resolvedUrl("../images/search_icon.png")
39 }
40
41
42=== added file 'images/back_icon@8.png'
43Binary files images/back_icon@8.png 1970-01-01 00:00:00 +0000 and images/back_icon@8.png 2013-07-19 19:18:28 +0000 differ
44=== modified file 'images/lap_icon@8.png'
45Binary files images/lap_icon@8.png 2013-06-21 23:19:57 +0000 and images/lap_icon@8.png 2013-07-19 19:18:28 +0000 differ
46=== modified file 'images/reset_icon@8.png'
47Binary files images/reset_icon@8.png 2013-06-21 23:19:57 +0000 and images/reset_icon@8.png 2013-07-19 19:18:28 +0000 differ
48=== modified file 'images/search_icon@8.png'
49Binary files images/search_icon@8.png 2013-06-15 21:21:19 +0000 and images/search_icon@8.png 2013-07-19 19:18:28 +0000 differ
50=== modified file 'timer/TimerPage.qml'
51--- timer/TimerPage.qml 2013-07-16 18:25:18 +0000
52+++ timer/TimerPage.qml 2013-07-19 19:18:28 +0000
53@@ -303,7 +303,7 @@
54
55 visible: false
56 hasClearButton: true
57- anchors { left: analogTimer.left; right: analogTimer.right; top: analogTimer.bottom; topMargin: units.gu(7)}
58+ anchors { left: analogTimer.left; right: analogTimer.right; top: analogTimer.bottom; topMargin: units.gu(10)}
59
60 placeholderText: i18n.tr("Timer One")
61 }
62@@ -348,7 +348,7 @@
63
64 back: ToolbarButton {
65 text: "Back";
66- iconSource: Qt.resolvedUrl("../images/reset_icon.png");
67+ iconSource: Qt.resolvedUrl("../images/back_icon.png");
68 visible: timerPage.state == "ADDPRESET" ? true : false;
69
70 onTriggered: {

Subscribers

People subscribed via source and target branches