Merge lp:~paolorotolo/ubuntu-clock-app/fix-for-1197908 into lp:ubuntu-clock-app/saucy

Proposed by Paolo Rotolo
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 183
Merged at revision: 185
Proposed branch: lp:~paolorotolo/ubuntu-clock-app/fix-for-1197908
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 40 lines (+15/-2)
1 file modified
timer/AnalogTimer.qml (+15/-2)
To merge this branch: bzr merge lp:~paolorotolo/ubuntu-clock-app/fix-for-1197908
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+184143@code.launchpad.net

Commit message

Timer: fixed hands reset (LP: #1197908).

Description of the change

Timer: fixed hands reset.
Please see: https://bugs.launchpad.net/ubuntu-clock-app/+bug/1197908

To post a comment you must log in.
183. By Paolo Rotolo

* Added search_timer.start();
* Fixed typo.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Testing fix now many times to ensure it is not reproducible any more.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

After testing it few more times, I can concur that this bug is finally fixed. Thank you very much Paolo!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'timer/AnalogTimer.qml'
2--- timer/AnalogTimer.qml 2013-09-03 19:22:41 +0000
3+++ timer/AnalogTimer.qml 2013-09-05 17:01:01 +0000
4@@ -41,6 +41,7 @@
5 // Timer function called by the main clock loop
6 function onTimerUpdate () {
7 if( timerOn ) {
8+ inProgressFlag = true;
9 remTime = totalTime - Math.floor((new Date() - startTime)/ 1000) - pauseTime;
10
11 if (remTime < 0) {
12@@ -64,14 +65,26 @@
13 }
14
15 // Function to disable timer and reset time
16+ Timer {
17+ id: reset_timer
18+
19+ interval: 200
20+ repeat: false
21+ onTriggered: {
22+ inProgressFlag = true;
23+ hourHand.rotationValue = minuteHand.rotationValue = secondHand.rotationValue = 0;
24+ inProgressFlag = false;
25+ }
26+ }
27+
28 function reset() {
29+ reset_timer.start();
30 timerOn = false;
31 state = "";
32 startTime = remTime = pauseTime = 0;
33- hourHand.rotationValue = minuteHand.rotationValue = secondHand.rotationValue = 0;
34 hours = minutes = seconds = totalTime = 0;
35 hourHand.timerValue = minuteHand.timerValue = secondHand.timerValue = 0;
36- }
37+ }
38
39 Repeater {
40 model: 12

Subscribers

People subscribed via source and target branches