Merge ~panfaust/kubuntu-packaging/+git/krfb:gcc6 into ~kubuntu-packagers/kubuntu-packaging/+git/krfb:kubuntu_yakkety_archive

Proposed by Jose Manuel Santamaria Lema on 2016-08-11
Status: Merged
Merged at revision: b38f945a648a1f9939b41cc39ca7e1c8b586abc9
Proposed branch: ~panfaust/kubuntu-packaging/+git/krfb:gcc6
Merge into: ~kubuntu-packagers/kubuntu-packaging/+git/krfb:kubuntu_yakkety_archive
Diff against target: 60 lines (+24/-5)
4 files modified
debian/changelog (+5/-0)
debian/patches/add_libpthread_to_krfb.diff (+3/-5)
debian/patches/kubuntu_krfb-max-gcc6.diff (+15/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Kubuntu Packagers 2016-08-11 Pending
Review via email: mp+302734@code.launchpad.net

Description of the Change

Add a patch from Fedora to fix a build failure with GCC 6. Note that there's also one in debian's git but I think the one from debian is not the correct solution to the problem because it puts some includes upside-down while this one seems to adress the problem directly and correclty.

This patch should be sent upstream sooner or later.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8c53311..d0856cc 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -14,6 +14,11 @@ krfb (4:16.04.3-0ubuntu1) UNRELEASED; urgency=medium
6 * New upstream release (16.04.2)
7 * New upstream release (16.04.3)
8
9+ [ José Manuel Santamaría Lema ]
10+ * Refresh add_libpthread_to_krfb.diff
11+ * Add kubuntu_krfb-max-gcc6.diff from Fedora to avoid a build failure
12+ with GCC 6.
13+
14 -- Clive Johnston <clivejo@kubuntu.org> Fri, 08 Jul 2016 01:18:06 +0100
15
16 krfb (4:15.12.3-0ubuntu1) xenial; urgency=medium
17diff --git a/debian/patches/add_libpthread_to_krfb.diff b/debian/patches/add_libpthread_to_krfb.diff
18index dfd8fad..62e321b 100644
19--- a/debian/patches/add_libpthread_to_krfb.diff
20+++ b/debian/patches/add_libpthread_to_krfb.diff
21@@ -1,8 +1,6 @@
22-Index: krfb/krfb/CMakeLists.txt
23-===================================================================
24---- krfb.orig/krfb/CMakeLists.txt 2014-09-24 14:08:49.843738219 +0200
25-+++ krfb/krfb/CMakeLists.txt 2014-09-24 14:08:49.843738219 +0200
26-@@ -125,6 +125,8 @@
27+--- a/krfb/CMakeLists.txt
28++++ b/krfb/CMakeLists.txt
29+@@ -102,6 +102,8 @@ if (X11_XTest_FOUND)
30 )
31 endif (X11_XTest_FOUND)
32
33diff --git a/debian/patches/kubuntu_krfb-max-gcc6.diff b/debian/patches/kubuntu_krfb-max-gcc6.diff
34new file mode 100644
35index 0000000..01e773e
36--- /dev/null
37+++ b/debian/patches/kubuntu_krfb-max-gcc6.diff
38@@ -0,0 +1,15 @@
39+Description: This patch fixes a build failure with GCC 6
40+Origin: http://pkgs.fedoraproject.org/cgit/rpms/krfb.git/tree/krfb-15.12.2-max-gcc6.patch
41+Forwarded: no
42+--- a/krfb/rfb.h
43++++ b/krfb/rfb.h
44+@@ -8,6 +8,9 @@
45+
46+ #include "rfb/rfb.h"
47+
48++#ifdef max // fix conflict with max() macro using gcc6
49++#undef max
50++#endif
51+ #undef TRUE
52+ #undef FALSE
53+
54diff --git a/debian/patches/series b/debian/patches/series
55index 98cd28e..cebcd57 100644
56--- a/debian/patches/series
57+++ b/debian/patches/series
58@@ -1 +1,2 @@
59 add_libpthread_to_krfb.diff
60+kubuntu_krfb-max-gcc6.diff

Subscribers

People subscribed via source and target branches