Merge ~panfaust/kubuntu-packaging/+git/akonadi:work into ~kubuntu-packagers/kubuntu-packaging/+git/akonadi:kubuntu_yakkety_archive
Status: | Merged |
---|---|
Merged at revision: | 517559c071096563bd356c887bbe1837713caefb |
Proposed branch: | ~panfaust/kubuntu-packaging/+git/akonadi:work |
Merge into: | ~kubuntu-packagers/kubuntu-packaging/+git/akonadi:kubuntu_yakkety_archive |
Diff against target: |
92 lines (+17/-13) 4 files modified
debian/changelog (+10/-12) debian/libkf5akonadicore5.lintian-overrides (+1/-0) debian/libkf5akonadicore5.symbols (+1/-1) debian/rules (+5/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kubuntu Packagers | Pending | ||
Review via email: mp+303187@code.launchpad.net |
Description of the change
This merge request contains 2 commits. The second commit is just fixing the format of the latest changelog entry.
The first commit re-introduces the -bin depend injection by libkf5akonadicore5 symbols file; this was removed in kubuntu to avoid circular dependencies, however that's not the correct solution.
They tried to fix the circular dependencies in debian here:
https:/
That's not the correct solution either. It moves the -bin dependency injection to other symbols file, so I have the impression that they weren't able to figure this out properly and they applied that wrong solution because they didn't find other way to do it.
The correct solution is adding something like this to the rules file:
lib_packages = $(filter lib%,$(shell dh_listpackages))
override_
This way we don't have circular dependencies and we can keep the -bin depend injection in the libkf5akonadicore5 symbols file, which is where it should be.
I think you got the correct solution here, but why are you excluding kdepimlibs-data?
and nitpicking: fo -> for in the changelog