Merge lp:~pali/ubuntu/raring/udev/hp-elitebook-8460p into lp:ubuntu/raring/udev

Proposed by Pali on 2013-04-05
Status: Needs review
Proposed branch: lp:~pali/ubuntu/raring/udev/hp-elitebook-8460p
Merge into: lp:ubuntu/raring/udev
Diff against target: 33 lines (+21/-0)
2 files modified
debian/patches/hp-elitebook-8460p.patch (+20/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~pali/ubuntu/raring/udev/hp-elitebook-8460p
Reviewer Review Type Date Requested Status
Martin Pitt 2013-04-05 Approve on 2013-04-09
Review via email: mp+157420@code.launchpad.net

Description of the change

This patch fixing buttons (Wireless switch, Ambient Light Sensor and System information button) on notebook HP EliteBook 8460p. Please consider to include this patch into ubuntu. Without this patch all three buttons have bad keycodes.

To post a comment you must log in.
Dimitri John Ledkov (xnox) wrote :

Is this upstream as well?

Pali (pali) wrote :

No I patched only this udev ubuntu version, because I'm using ubuntu.

Pali (pali) wrote :

+ENV{DMI_VENDOR}=="Hewlett-Packard", ATTR{[dmi/id]product_name}=="HP EliteBook 8446p", RUN+="keymap $name hewlett-packard_elitebook-8460p"

"HP EliteBook 8446p" --> this is bad

Martin Pitt (pitti) wrote :

Pali [2013-04-09 13:40 -0000]:
> "HP EliteBook 8446p" --> this is bad

Thanks for spotting, sorry about that. Fixed in a followup commit.

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Pali (pali) wrote :

So what is state of this patch? It is already in upstream, but not in ubuntu...

Unmerged revisions

234. By Pali on 2013-04-05

Add patch for HP EliteBook 8460p buttons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/hp-elitebook-8460p.patch'
2--- debian/patches/hp-elitebook-8460p.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/hp-elitebook-8460p.patch 2013-04-05 15:59:22 +0000
4@@ -0,0 +1,20 @@
5+Index: udev/extras/keymap/95-keymap.rules
6+===================================================================
7+--- udev.orig/extras/keymap/95-keymap.rules 2013-04-05 16:48:02.933377745 +0200
8++++ udev/extras/keymap/95-keymap.rules 2013-04-05 16:48:31.917376765 +0200
9+@@ -91,6 +91,7 @@
10+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*[tT][aA][bB][lL][eE][tT]*", RUN+="keymap $name hewlett-packard-tablet"
11+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*[pP][aA][vV][iI][lL][iI][oO][nN]*", RUN+="keymap $name hewlett-packard-pavilion"
12+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*Compaq*|*EliteBook*|*2230s*", RUN+="keymap $name hewlett-packard-compaq_elitebook"
13++ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*8460p*", RUN+="keymap $name hewlett-packard-elitebook-8460p"
14+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*Presario*CQ*", RUN+="keymap $name 0xD8 f21 0xD9 f21"
15+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*2510p*|*2530p*|HP G60 Notebook PC", RUN+="keymap $name hewlett-packard-2510p_2530p"
16+ ENV{DMI_VENDOR}=="Hewlett-Packard*", ATTR{[dmi/id]product_name}=="*[tT][xX]2*", RUN+="keymap $name hewlett-packard-tx2"
17+Index: udev/extras/keymap/keymaps/hewlett-packard-elitebook-8460p
18+===================================================================
19+--- /dev/null 1970-01-01 00:00:00.000000000 +0000
20++++ udev/extras/keymap/keymaps/hewlett-packard-elitebook-8460p 2013-04-05 17:44:46.937263740 +0200
21+@@ -0,0 +1,3 @@
22++0xF8 wlan # Wireless HW switch button
23++0xB3 prog1 # Fn+F11 - Ambient Light Sensor button
24++0xB1 prog2 # Fn+ESC - System information button
25
26=== modified file 'debian/patches/series'
27--- debian/patches/series 2013-03-19 14:31:16 +0000
28+++ debian/patches/series 2013-04-05 15:59:22 +0000
29@@ -16,3 +16,4 @@
30 # disabled until raring+1 when we'll move to logind
31 #udev-acl-with-standalone-logind.patch
32 builtin-uaccess.patch
33+hp-elitebook-8460p.patch

Subscribers

People subscribed via source and target branches

to all changes: