Code review comment for lp:~pali/ubuntu/oneiric/pulseaudio/pulseaudio

I built your branch, but it failed to install. The issue was the way you are 'stop'ing in the upstart script.
exiting in a 'script' section will cause upstart to try to respawn the job. Eventually that will hit the respawn limit.

So, the changes I suggest are:
 * fix the issue of 'start' with a pre-start script (you can see a similar example in the libvirt-bin package).
 * you should also probably do the 'mkdir -p /var/run/pulse' in pre-start.
 * Also, if you use dh_installinit, you can actually leave the old .init file around, and do not have to modify debian/pulseaudio.install as dh_installinit will do that for you.
   - mkdir -p $(CURDIR)/debian/tmp/etc/init
   - cp -a $(CURDIR)/debian/pulseaudio.upstart $(CURDIR)/debian/tmp/etc/init/pulseaudio.conf
   + dh_installinit
 * re-add the pulseaudio.init
   bzr revert -r 143 debian/pulseaudio.init
   bzr add debian/pulseaudio.init