Merge ~paelzer/uvtool:add-qxl-as-default into uvtool:master

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 27dc00fc3840ac32aa7c3d3bc34bf44a5bc3f5b2
Proposed branch: ~paelzer/uvtool:add-qxl-as-default
Merge into: uvtool:master
Diff against target: 17 lines (+6/-1)
1 file modified
template.xml (+6/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Robie Basak Approve
Review via email:
To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

I don't see any problem with this and I trust your judgement on what the sensible default should be. Feel free to merge when you consider ready (eg. Andreas' test).

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Taking a look.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Confirmed spice and qxl get added to new vms.

In disco, after installing ubuntu-desktop and rebooting, X starts up just fine, and logs show it's using xorg's

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Pushed and merged.

@Rbasak - could you make this a bugfix upload to Disco still as that is where the offending changes land?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/template.xml b/template.xml
2index 3c795c1..b76bcb8 100644
3--- a/template.xml
4+++ b/template.xml
5@@ -20,6 +20,11 @@
6 <graphics type='vnc' autoport='yes' listen=''>
7 <listen type='address' address=''/>
8 </graphics>
9- <video/>
10+ <graphics type='spice' autoport='yes' listen=''>
11+ <listen type='address' address=''/>
12+ </graphics>
13+ <video>
14+ <model type='qxl'/>
15+ </video>
16 </devices>
17 </domain>


People subscribed via source and target branches