Merge ~paelzer/uvtool:fix-libvirt-dependency into uvtool:ubuntu/devel

[Christian Ehrhardt ]

Hi,
part of working on bug 1694159 is to drop the libvirt-bin dependency of uvtool-libvirt.
I don't know if you have any issues with it considering your backport-from-git strategy, but we can discuss that if needed.

TL;DR libvirt-bin is only a transitional package since Yakkety, we want to complete the drop of dependencies towards 18.04 so that we can remove the package in 18.10.

But fixing as much as possible ahead of time - e..g in artful now, makes the small transition later easier. Therefore a merge request for uvtools artful packaging mapping the new package names.

I made sure the commit message explains the details why which replacement dependencies where chosen, that way people can find it without knowing the MP to read the reasoning.

[Christian Ehrhardt  (paelzer)]

Note: since we need daemon-system AND clients anyway as outlined int he commit.
And in recent Ubuntu releases libvirt-bin looks like this:

Package: libvirt-bin
Source: libvirt
Version: 2.5.0-3ubuntu5~cloud0
Depends: libvirt-daemon-system (>= 2.5.0-3ubuntu5~cloud0), libvirt-clients (>= 2.5.0-3ubuntu5~cloud0)

The change is actually a no-op (there are other cases where we only replace with one of the new packages). But for this the change should have no impact other than dropping the outdated libvirt-bin dependency.

[Christian Ehrhardt  (paelzer)]

Just re-pushed a commit message change to let not only debian/changelog, but also a commit message list the related launchpad bug.

[Robie Basak (racb)]

Would it be OK to say:

Depends: libvirt-daemon-system | libvirt-bin, libvirt-clients | libvirt-bin? This would make backporting easier.

[Christian Ehrhardt  (paelzer)]

Hi Robie,
I see where you are heading to in regard to the backports, and I think something like that is ok - as it will allow us to drop libvirt-bin some day.
But the split is different as libvirt-bin split into libvirt-daemon, libvirt-daemon-system and libvirt-clients.

I think it then should look like:
Depends: libvirt-daemon-system, libvirt-clients | libvirt-bin
Which is: new | old

[Christian Ehrhardt  (paelzer)]

Oh I see the comma and pipe separation only now (too early).
Strike my former comment and set "yes" :-)

[Christian Ehrhardt  (paelzer)]

I pushed a fix to the branch a while ago, in the meantime I also tested it.
While the A|B style dependencies will not make it show up to be autoremovable it is enough to be able to do
 $ apt remove libvirt-bin
without dragging anything down with it.

[Christian Ehrhardt  (paelzer)]

Ping any update - I'd really want to get this in shape looking forward to 18.04

diff --git a/debian/changelog b/debian/changelog
index 4e2e917..15f1064 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+uvtool (0~git122-0ubuntu2) artful; urgency=medium
+
+  * Update Dependencies to match new libvirt package names (LP: #1694159)
+
+ -- Christian Ehrhardt <[e-mail]>  Tue, 30 May 2017 10:29:14 +0200
+
 uvtool (0~git122-0ubuntu1) artful; urgency=medium
 
   * New upstream snapshot:
diff --git a/debian/control b/debian/control
index d608c97..9f509bf 100644
--- a/debian/control
+++ b/debian/control
@@ -28,7 +28,8 @@ Description: Library and tools for using Ubuntu Cloud images
 
 Package: uvtool-libvirt
 Architecture: all
-Depends: libvirt-bin,
+Depends: libvirt-daemon-system | libvirt-bin,
+         libvirt-clients | libvirt-bin,
          python-libvirt,
          python-simplestreams,
          python-lxml,
@@ -44,5 +45,5 @@ Depends: libvirt-bin,
 Recommends: qemu-kvm, cpu-checker
 Description: Library and tools for using Ubuntu Cloud Images with libvirt
  This package provides libvirt-specific tools for consuming Ubuntu Cloud
- images. Since it depends on libvirt-bin, installing this package will also
+ images. Since it depends on libvirt, installing this package will also
  install libvirt which by defaults configures it with a bridge on your system.