Merge ~paelzer/update-notifier/+git/update-notifier:lp-1893716-reduce-login-overhead-JAMMY-nongu into update-notifier:master

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

Resubmit of https://code.launchpad.net/~paelzer/ubuntu/+source/update-notifier/+git/update-notifier/+merge/417912 against the LP hosted main repository.

[Brian Murray (brian-murray)]

This looks fine but I wonder if we extended the time frame see my inline comment.

[Christian Ehrhardt  (paelzer)]

Hi Brian,
I didn't want to be too aggressive with my proposal ...

On one hand we have the impact that is rather low after the change, no matter if we use 1h or 1d.

- manual login: humans are slow, makes no big difference even if checking every time.
- auto-logins: before any rate limiting this could go into the millions per hour which now get one check \o/, bumping this up to 1d doesn't make too much difference

On the other hand you are right it does try to tell you if

a) one of your -hwe packages is no more supported (think hirsute based but hirsute EOL)
b) about matching replacements

None of that changes on an hourly base, a day will work just as much indeed.

I'll bumped it to a day.
Will you merge and upload this later or should I?

[Christian Ehrhardt  (paelzer)]

I heard that you are away, given the time in the cycle and that you are generally ok with it I did an upload now and merged it in the repository.

diff --git a/debian/95-hwe-eol b/debian/95-hwe-eol
index 3b4bd13..92d0c7d 100755
--- a/debian/95-hwe-eol
+++ b/debian/95-hwe-eol
@@ -1,5 +1,11 @@
 #!/bin/sh
 
+# this stamp is created and updated by /usr/lib/update-notifier/update-motd-hwe-eol
+stamp="/var/lib/update-notifier/hwe-eol"
+
+# do not try to refresh this more than once per day
+[ -z "$(find "$stamp" -newermt 'now-1 days' 2> /dev/null)" ] && exit 0
+
 if [ -x /usr/lib/update-notifier/update-motd-hwe-eol ]; then
     exec /usr/lib/update-notifier/update-motd-hwe-eol
 fi
diff --git a/debian/changelog b/debian/changelog
index 731ead1..6184ddb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+update-notifier (3.192.54) jammy; urgency=medium
+
+  * d/95-hwe-eol: do not update eol data more than once per hour (LP: #1893716)
+
+ -- Christian Ehrhardt <[e-mail]>  Wed, 30 Mar 2022 12:20:47 +0200
+
 update-notifier (3.192.53) jammy; urgency=medium
 
   * data/list-oem-metapackages: Complete the transition to apt_pkg which was