Merge ~paelzer/ubuntu/+source/virt-manager:merge-2.2.1-4-groovy into ubuntu/+source/virt-manager:ubuntu/groovy-devel

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4238/+packages

[Christian Ehrhardt  (paelzer)]

Confirmed, this does not need the libvirt build from the PPA - just the virt-manager fix is enough.
Would be awesome to get this uploaded soon to SRU then before groovy freezes even more.

[Andreas Hasenack (ahasenack)]

Previous version (takes ages):
  38191 ? Sl 0:12 \_ /usr/bin/qemu-img create -f qcow2 -o preallocation=falloc,compat=1.1,lazy_refcounts /var/lib/libvirt/images/ubuntu20.04.qcow2 26214400K

New version:
root@nsn7:~# apt-cache policy virt-manager
virt-manager:
  Installed: 1:2.2.1-4ubuntu2~ppa1
  Candidate: 1:2.2.1-4ubuntu2~ppa1
  Version table:
 *** 1:2.2.1-4ubuntu2~ppa1 500
        500 http://ppa.launchpad.net/ci-train-ppa-service/4238/ubuntu groovy/main amd64 Packages
        500 http://ppa.launchpad.net/ci-train-ppa-service/4238/ubuntu groovy/main i386 Packages
        100 /var/lib/dpkg/status
     1:2.2.1-4ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu groovy/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu groovy/universe i386 Packages

Was so wuick I couldn't grab the ps output on the first try. Ok, got it now:
  47925 ? Sl 0:00 \_ /usr/bin/qemu-img create -f qcow2 -o preallocation=metadata,compat=1.1,lazy_refcounts /var/lib/libvirt/images/ubuntu20.04.qcow2 26214400K

DEP3 header has a minor typo "existin":
Backport-Note: upstream also changed some tests not existin in groovy

Ack to the removed test hunks

review: Approve

[Christian Ehrhardt  (paelzer)]

Thanks, typo fixed

[Christian Ehrhardt  (paelzer)]

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/virt-manager
 * [new tag] upload/1%2.2.1-4ubuntu2 -> upload/1%2.2.1-4ubuntu2

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading virt-manager_2.2.1-4ubuntu2.dsc: done.
  Uploading virt-manager_2.2.1-4ubuntu2.debian.tar.xz: done.
  Uploading virt-manager_2.2.1-4ubuntu2_source.buildinfo: done.
  Uploading virt-manager_2.2.1-4ubuntu2_source.changes: done.
Successfully uploaded packages.

[Christian Ehrhardt  (paelzer)]

migrated
 virt-manager | 1:2.2.1-4ubuntu2 | groovy/universe | source, all

diff --git a/debian/changelog b/debian/changelog
index cee8249..3bb98cd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+virt-manager (1:2.2.1-4ubuntu2) groovy; urgency=medium
+
+  * d/p/lp-1847105-addstorage-Return-to-using-qcow2-sparse-by-default.patch:
+    fix slow disk allocation when using the defaults to to falloc (LP: #1847105)
+
+ -- Christian Ehrhardt <[e-mail]>  Mon, 21 Sep 2020 16:28:36 +0200
+
 virt-manager (1:2.2.1-4ubuntu1) groovy; urgency=medium
 
   * Merge with Debian unstable. Remaining changes:
diff --git a/debian/patches/lp-1847105-addstorage-Return-to-using-qcow2-sparse-by-default.patch b/debian/patches/lp-1847105-addstorage-Return-to-using-qcow2-sparse-by-default.patch
new file mode 100644
index 0000000..9e5d819
--- /dev/null
+++ b/debian/patches/lp-1847105-addstorage-Return-to-using-qcow2-sparse-by-default.patch
@@ -0,0 +1,55 @@
+From ba08f84b3408744e9aa9763d100e8aa217c1f5ff Mon Sep 17 00:00:00 2001
+From: Cole Robinson <[e-mail]>
+Date: Sat, 19 Sep 2020 18:06:45 -0400
+Subject: [PATCH] addstorage: Return to using qcow2 sparse by default
+
+https://bugzilla.redhat.com/show_bug.cgi?id=1759454
+
+See 15a6a7e2105440df528f75c4df4d2471df28bd1e
+
+The idea behind virt-manager's sparse vs nonsparse default, is that if
+the user selected 'raw' for as the default image format, assume they
+want to maximize performance, so fully allocate the disk.
+
+qcow2 didn't support anything except sparse, so the sparse=True vs
+sparse=False made no difference. So we always set sparse=False
+
+Then qcow2 grows non-sparse support, and virt-manager is suddenly
+defaulting to it, which is not the intention.
+
+Default to sparse when requested format isn't raw
+
+Signed-off-by: Cole Robinson <[e-mail]>
+
+Backport-Note: upstream also changed some tests not existin in groovy
+Origin: upstream, https://github.com/virt-manager/virt-manager/commit/ba08f84b34
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1847105
+Last-Update: 2020-09-21
+
+---
+ virtManager/device/addstorage.py  | 8 ++++++--
+ 3 files changed, 11 insertions(+), 11 deletions(-)
+
+--- a/virtManager/device/addstorage.py
++++ b/virtManager/device/addstorage.py
+@@ -176,14 +176,18 @@ class vmmAddStorage(vmmGObjectUI):
+         if disk.wants_storage_creation():
+             pool = disk.get_parent_pool()
+             size = uiutil.spin_get_helper(self.widget("storage-size"))
+-            sparse = False
++            fmt = self.conn.get_default_storage_format()
++
++            # If the user changed the default disk format to raw, assume
++            # they want to maximize performance, so fully allocate the
++            # disk image. Otherwise use sparse
++            sparse = fmt != 'raw'
+ 
+             vol_install = virtinst.DeviceDisk.build_vol_install(
+                 disk.conn, os.path.basename(disk.path), pool,
+                 size, sparse)
+             disk.set_vol_install(vol_install)
+ 
+-            fmt = self.conn.get_default_storage_format()
+             if disk.get_vol_install().supports_format():
+                 log.debug("Using default prefs format=%s for path=%s",
+                     fmt, disk.path)
diff --git a/debian/patches/series b/debian/patches/series
index 06e24c9..9bb79e9 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 Use-usr-bin-python.patch
 mark-libvirt-lxc.patch
 legacy-images.patch
+lp-1847105-addstorage-Return-to-using-qcow2-sparse-by-default.patch