Merge ~paelzer/ubuntu/+source/ssoclient:drop-py2 into ~paelzer/ubuntu/+source/ssoclient:importer/ubuntu/focal-devel

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: d9608d1eb5b92549fe0ece51c096708154087a77
Proposed branch: ~paelzer/ubuntu/+source/ssoclient:drop-py2
Merge into: ~paelzer/ubuntu/+source/ssoclient:importer/ubuntu/focal-devel
Diff against target: 73 lines (+11/-21)
4 files modified
debian/changelog (+10/-0)
debian/control (+0/-17)
debian/rules (+1/-1)
debian/tests/control (+0/-3)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+377352@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Not in main, therefore a local git repo.

Tests work in VM:
...
autopkgtest [09:53:00]: test command1: python3 -c "import ssoclient; print(ssoclient.__version__)"
autopkgtest [09:53:00]: test command1: [-----------------------
2.1.1
autopkgtest [09:53:02]: test command1: -----------------------]
autopkgtest [09:53:03]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 PASS
autopkgtest [09:53:03]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS
qemu-system-x86_64: terminating on signal 15 from pid 20454 (/usr/bin/python3)

Build in PPA:
https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3885/+packages

Bileto run ongoing at ticket: https://bileto.ubuntu.com/#/ticket/3885

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

+1, LGTM.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks, uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index fe199d9..6d801db 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+ssoclient (2.1.2) focal; urgency=medium
7+
8+ * drop python2 for Ubuntu 20.04
9+ - d/control: drop python2 build dependencies
10+ - d/control: drop python-ssoclient package
11+ - d/t/control: drop testing the python2 binary package
12+ - d/rules: drop python2 from dh call
13+
14+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 09 Jan 2020 08:04:42 +0100
15+
16 ssoclient (2.1.1build1) focal; urgency=medium
17
18 * No-change rebuild to generate dependencies on python2.
19diff --git a/debian/control b/debian/control
20index 4cf9b60..8e98306 100644
21--- a/debian/control
22+++ b/debian/control
23@@ -4,11 +4,6 @@ Priority: extra
24 Maintainer: Ricardo Kirkner <ricardo.kirkner@canonical.com>
25 Build-Depends: debhelper (>= 9),
26 dh-python,
27- python-all (>= 2.7),
28- python-setuptools,
29- python-requests,
30- python-requests-oauthlib,
31- python-mock,
32 python3-all (>= 3.4),
33 python3-setuptools,
34 python3-requests,
35@@ -18,18 +13,6 @@ Homepage: https://launchpad.net/~canonical-isd-hackers/canonical-identity-provid
36 Standards-Version: 3.9.6
37 X-Python3-Version: >= 3.4
38
39-Package: python-ssoclient
40-Architecture: all
41-Depends: python-requests-oauthlib,
42- python-requests,
43- ${misc:Depends},
44- ${python:Depends}
45-Description: Simple client for the Ubuntu One SSO API (Python 2)
46- This package provides a client based on a thin wrapper of
47- the Ubuntu One SSO API (v2).
48- .
49- This package installs the client for Python 2.
50-
51 Package: python3-ssoclient
52 Architecture: all
53 Depends: python3-requests-oauthlib,
54diff --git a/debian/rules b/debian/rules
55index 05b6711..eb9c744 100755
56--- a/debian/rules
57+++ b/debian/rules
58@@ -4,4 +4,4 @@
59 export PYBUILD_NAME = ssoclient
60
61 %:
62- dh $@ --with python2,python3 --buildsystem=pybuild
63+ dh $@ --with python3 --buildsystem=pybuild
64diff --git a/debian/tests/control b/debian/tests/control
65index 1ddc050..c62d633 100644
66--- a/debian/tests/control
67+++ b/debian/tests/control
68@@ -1,5 +1,2 @@
69 Test-Command: python3 -c "import ssoclient; print(ssoclient.__version__)"
70 Depends: python3-ssoclient
71-
72-Test-Command: python -c "import ssoclient; print(ssoclient.__version__)"
73-Depends: python-ssoclient

Subscribers

People subscribed via source and target branches

to all changes: