Merge ~paelzer/ubuntu/+source/seabios:lp-1793725-fix-FTBFS-cosmic into ubuntu/+source/seabios:ubuntu/cosmic-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 56f6844944da2b9e139199a9799809c16f7298e4
Merge reported by: Christian Ehrhardt 
Merged at revision: 56f6844944da2b9e139199a9799809c16f7298e4
Proposed branch: ~paelzer/ubuntu/+source/seabios:lp-1793725-fix-FTBFS-cosmic
Merge into: ubuntu/+source/seabios:ubuntu/cosmic-devel
Diff against target: 83 lines (+63/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/lp-1793725-Fix-building-of-legacy-acpi-tables.patch (+54/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+355492@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

This is the message that confirms that old iasl was already truncating the name, albeit silently: https://mail.coreboot.org/pipermail/seabios/2018-July/012371.html

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I checkd rom sizes as those changing was an issue in the past (new toolchain, so you never know).
But the results are fine.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/seabios
 * [new tag] upload/1.11.1-1ubuntu1 -> upload/1.11.1-1ubuntu1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

uploaded and checking migration

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8982cb3..23afbec 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+seabios (1.11.1-1ubuntu1) cosmic; urgency=medium
7+
8+ * d/p/lp-1793725-Fix-building-of-legacy-acpi-tables.patch:
9+ avoid FTBFS due to newer IASL toolchain generating names
10+ of different length (LP: #1793725)
11+
12+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 21 Sep 2018 13:22:40 +0200
13+
14 seabios (1.11.1-1) unstable; urgency=medium
15
16 * new upstream release
17diff --git a/debian/patches/lp-1793725-Fix-building-of-legacy-acpi-tables.patch b/debian/patches/lp-1793725-Fix-building-of-legacy-acpi-tables.patch
18new file mode 100644
19index 0000000..d727298
20--- /dev/null
21+++ b/debian/patches/lp-1793725-Fix-building-of-legacy-acpi-tables.patch
22@@ -0,0 +1,54 @@
23+From 8c3f57ea1217ea0c80a72898bc35baa0e14af0e0 Mon Sep 17 00:00:00 2001
24+From: Kevin O'Connor <kevin@koconnor.net>
25+Date: Sun, 15 Jul 2018 10:05:14 -0400
26+Subject: [PATCH] ssdt: Fix building of legacy acpi tables on current iasl
27+ compiler
28+
29+Recent versions of the iasl compiler raise an error if the table id is
30+longer than 8 characters. Older versions of iasl would silently
31+truncate the table id to 8 characters. Change the ssdt-misc and
32+ssdt-pcihp files to use an 8 character id - this should not directly
33+impact the generated aml code as the table id was already being
34+truncated - but may help those wishing to manually compile the tables.
35+
36+Reported by Michael Tokarev, Vivia Nikolaidou, and several others.
37+
38+Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
39+
40+Origin: upstream, https://git.seabios.org/cgit/seabios.git/commit/?id=8c3f57ea1217ea0c80a72898bc35baa0e14af0e0
41+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1793725
42+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901462
43+Last-Update: 2018-09-21
44+
45+---
46+ src/fw/ssdt-misc.dsl | 2 +-
47+ src/fw/ssdt-pcihp.dsl | 2 +-
48+ 2 files changed, 2 insertions(+), 2 deletions(-)
49+
50+diff --git a/src/fw/ssdt-misc.dsl b/src/fw/ssdt-misc.dsl
51+index acc850e8..d1d2c9e3 100644
52+--- a/src/fw/ssdt-misc.dsl
53++++ b/src/fw/ssdt-misc.dsl
54+@@ -1,6 +1,6 @@
55+ ACPI_EXTRACT_ALL_CODE ssdp_misc_aml
56+
57+-DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
58++DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSU", 0x1)
59+ {
60+
61+ /****************************************************************
62+diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl
63+index cb24c11c..518a5ebf 100644
64+--- a/src/fw/ssdt-pcihp.dsl
65++++ b/src/fw/ssdt-pcihp.dsl
66+@@ -1,6 +1,6 @@
67+ ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml
68+
69+-DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
70++DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPC", 0x1)
71+ {
72+
73+ /****************************************************************
74+--
75+2.17.1
76+
77diff --git a/debian/patches/series b/debian/patches/series
78new file mode 100644
79index 0000000..290026e
80--- /dev/null
81+++ b/debian/patches/series
82@@ -0,0 +1 @@
83+lp-1793725-Fix-building-of-legacy-acpi-tables.patch

Subscribers

People subscribed via source and target branches