Merge ~paelzer/ubuntu/+source/rsyslog:fix-1827253-container-apparmor-bionic into ubuntu/+source/rsyslog:ubuntu/bionic-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 47ae4d1ba9882e15a9cb62600eb190b7671b740b
Merged at revision: 47ae4d1ba9882e15a9cb62600eb190b7671b740b
Proposed branch: ~paelzer/ubuntu/+source/rsyslog:fix-1827253-container-apparmor-bionic
Merge into: ubuntu/+source/rsyslog:ubuntu/bionic-devel
Diff against target: 28 lines (+9/-0)
2 files modified
debian/changelog (+8/-0)
debian/usr.sbin.rsyslogd (+1/-0)
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) Approve
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+374072@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Trivial fix in default-disabled apparmor profile, but to be sure against e.g. unexpected FTBFS.
Test build PPA: https://launchpad.net/~paelzer/+archive/ubuntu/bug-1827253-rsyslog-apparmor

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Like you stated to Simon, perfect bug. Root cause, a way to reproduce, a workaround, a patch included with SRU template. I saw you added changelog adding credits, change is trivial but PPA confirmed no FTBFS. Version look good to disco (4.1). +1 on my side.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

thanks - tagged and uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9b7c094..45c012d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+rsyslog (8.32.0-1ubuntu4.1) bionic; urgency=medium
7+
8+ [ Simon Deziel ]
9+ * d/usr.sbin.rsyslogd: allow reading/mmap'ing rsyslog binary
10+ This is required for usage inside containers (LP: #1827253)
11+
12+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Mon, 14 Oct 2019 08:54:45 +0200
13+
14 rsyslog (8.32.0-1ubuntu4) bionic; urgency=medium
15
16 [ Jamie Strandboge ]
17diff --git a/debian/usr.sbin.rsyslogd b/debian/usr.sbin.rsyslogd
18index d9b502a..9af2681 100644
19--- a/debian/usr.sbin.rsyslogd
20+++ b/debian/usr.sbin.rsyslogd
21@@ -29,6 +29,7 @@
22 /var/spool/rsyslog/ r,
23 /var/spool/rsyslog/** rwk,
24
25+ /usr/sbin/rsyslog mr,
26 /usr/lib{,32,64}/{,@{multiarch}/}rsyslog/*.so mr,
27
28 /dev/tty* rw,

Subscribers

People subscribed via source and target branches