Code review comment for ~paelzer/ubuntu/+source/qemu:merge-5.2+dfsg-6-hirsute

Lucas Kanashiro (lucaskanashiro) wrote :

* Changelog:
  - [√] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [√] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [-] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

LGTM, +1.

The only thing I found was a typo in this commit message (changelog is fine):

commit 17d5c87a13fda8870bb52c37bb7676e65b35b4bd
Author: Christian Ehrhardt <email address hidden>
Date: Wed Jan 8 16:45:41 2020 +0100

    d/qemu-system-x86.README.Debian: add into about nesting changes

    Signed-off-by: Christian Ehrhardt <email address hidden>

s/into/info.

review: Approve

« Back to merge proposal