Merge ~paelzer/ubuntu/+source/qemu:bug-1847361-miss-old-so-on-upgrade-UBUNTU into ubuntu/+source/qemu:ubuntu/focal-devel

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3961

[Rafael David Tinoco (rafaeldtinoco)]

I'll review this one

[Christian Ehrhardt  (paelzer)]

New builds in the PPA following the upstream discussion.
No "major" changes thou, never the less I'll force push the updates to be available here as well.

[Christian Ehrhardt  (paelzer)]

From the build log:
base build:
module support yes
alt path mod load yes

static/xen/microvm build:
module support no
alt path mod load no

This is just as I wanted it and shows that it works to build in both cases.

[Rafael David Tinoco (rafaeldtinoco)]

STATUS: +1 (approved)

# checklist for fixes
----------------------------
 [.] changelog entry correct, targeted to correct codename
 [.] update-maintainer has been run previously
 ----
 [.] changes forwarded upstream/debian (if appropriate)
 [.] patches match what was proposed upstream
 ----
 [.] patches correctly included in debian/patches/series?
 [.] patches have correct DEP3 metadata
 ----
 [.] verified dpkg-buildpackage -S and -b
 [-] autopkgtest against PPA or built package passes
     - relying in upgrade test for this change only
 ----
 [!] testcase provided
     - checking temporary created library dirs ant contents
 [.] was able to reproduce
 [.] fix solved provided testcase
----------------------------
[.] = ok
[x] = not ok
[?] = question
[!] = note
[-] = n/a

# relevant stdout:

(c)rafaeldtinoco@qemudevel:.../Debian_1_4.2-3ubuntu2$ ls -lahtr
total 1.3M
drwxr-xr-x 3 root root 60 Mar 10 20:54 ..
drwxr-xr-x 2 root root 160 Mar 10 20:54 .
-rw-r--r-- 1 root root 591K Mar 10 23:28 ui-gtk.so
-rw-r--r-- 1 root root 73K Mar 10 23:28 audio-pa.so
-rw-r--r-- 1 root root 181K Mar 10 23:28 block-iscsi.so
-rw-r--r-- 1 root root 151K Mar 10 23:28 block-curl.so
-rw-r--r-- 1 root root 155K Mar 10 23:28 block-ssh.so
-rw-r--r-- 1 root root 122K Mar 10 23:28 block-rbd.so
(c)rafaeldtinoco@qemudevel:.../Debian_1_4.2-3ubuntu2$ pwd
/var/run/qemu/Debian_1_4.2-3ubuntu2

review: Approve

[Christian Ehrhardt  (paelzer)]

Thanks for this pre-check.
Lets see how the upstream discussion evolves the next few days.

4683e8d... by Christian Ehrhardt  on 2020-03-13

changelog MEGRE

Signed-off-by: Christian Ehrhardt <email address hidden>

dbe2005... by Christian Ehrhardt  on 2020-03-13

d/rules: generate maintainer scripts matching package version

Signed-off-by: Christian Ehrhardt <email address hidden>

7d44fb3... by Christian Ehrhardt  on 2020-03-13

d/rules: enable --enable-module-upgrades where --enable-modules is set

Signed-off-by: Christian Ehrhardt <email address hidden>

2212796... by Christian Ehrhardt  on 2020-03-13

d/p/ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch: avoid unnecessary IOTLB transactions (LP: #1866207)

Signed-off-by: Christian Ehrhardt <email address hidden>

9eea3bd... by Christian Ehrhardt  on 2020-03-13

cahngelog: avoid unnecessary IOTLB transactions (LP: #1866207)

Signed-off-by: Christian Ehrhardt <email address hidden>

[Christian Ehrhardt  (paelzer)]

Another set of pre-builds and checks is good

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/qemu
 * [new tag] upload/1%4.2-3ubuntu2 -> upload/1%4.2-3ubuntu2

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading qemu_4.2-3ubuntu2.dsc: done.
  Uploading qemu_4.2-3ubuntu2.debian.tar.xz: done.
  Uploading qemu_4.2-3ubuntu2_source.buildinfo: done.
  Uploading qemu_4.2-3ubuntu2_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index 89089bb..d73be7f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,17 @@
+qemu (1:4.2-3ubuntu2) focal; urgency=medium
+
+  * allow qemu to load old modules post upgrade (LP: #1847361)
+    - d/p/ubuntu/lp-1847361-modules-load-upgrade.patch: to fallback module
+      load to a versioned path
+    - d/qemu-block-extra.*.in, d/qemu-system-gui.*.in: save shared objects on
+      upgrade
+    - d/rules: generate maintainer scripts matching package version on build
+    - d/rules: enable --enable-module-upgrades where --enable-modules is set
+  * d/p/ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch:
+    avoid unnecessary IOTLB transactions (LP: #1866207)
+
+ -- Christian Ehrhardt <[e-mail]>  Mon, 02 Mar 2020 15:21:27 +0100
+
 qemu (1:4.2-3ubuntu1) focal; urgency=medium
 
   * Merge with Debian testing, remaining changes:
diff --git a/debian/patches/series b/debian/patches/series
index c9fce99..2371880 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -13,3 +13,5 @@ ubuntu/lp-1857033-i386-Add-macro-for-stibp.patch
 ubuntu/lp-1857033-i386-Add-new-CPU-model-Cooperlake.patch
 lp-1859527-virtio-blk-fix-out-of-bounds-access-to-bitmap-in-not.patch
 ubuntu/vhost-user-gpu-Drop-trailing-json-comma.patch
+ubuntu/lp-1847361-modules-load-upgrade.patch
+ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch
diff --git a/debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch b/debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch
new file mode 100644
index 0000000..056f2e0
--- /dev/null
+++ b/debian/patches/ubuntu/lp-1847361-modules-load-upgrade.patch
@@ -0,0 +1,125 @@
+From ab7e28b0905b1e2daeb5d582cf0f0ce33ea47317 Mon Sep 17 00:00:00 2001
+From: Christian Ehrhardt <[e-mail]>
+Date: Mon, 2 Mar 2020 15:12:53 +0100
+Subject: [PATCH] modules: load modules from versioned /var/run dir
+
+On upgrades the old .so files usually are replaced. But on the other
+hand since a qemu process represents a guest instance it is usually kept
+around.
+
+That makes late addition of dynamic features e.g. 'hot-attach of a ceph
+disk' fail by trying to load a new version of e.f. block-rbd.so into an
+old still running qemu binary.
+
+This adds a fallback to also load modules from a versioned directory in the
+temporary /var/run path. That way qemu is providing a way for packaging
+to store modules of an upgraded qemu package as needed until the next reboot.
+
+Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1847361
+Signed-off-by: Christian Ehrhardt <[e-mail]>
+
+Forwarded: yes, https://lists.nongnu.org/archive/html/qemu-devel/2020-03/msg01593.html
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1847361
+Last-Update: 2020-03-02
+
+---
+ configure     | 15 +++++++++++++++
+ util/module.c | 14 ++++++++++++++
+ 2 files changed, 29 insertions(+)
+
+--- a/configure
++++ b/configure
+@@ -404,6 +404,7 @@ EXESUF=""
+ DSOSUF=".so"
+ LDFLAGS_SHARED="-shared"
+ modules="no"
++module_upgrades="no"
+ prefix="/usr/local"
+ mandir="\${prefix}/share/man"
+ datadir="\${prefix}/share"
+@@ -995,6 +996,10 @@ for opt do
+   --disable-modules)
+       modules="no"
+   ;;
++  --disable-module-upgrades) module_upgrades="no"
++  ;;
++  --enable-module-upgrades) module_upgrades="yes"
++  ;;
+   --cpu=*)
+   ;;
+   --target-list=*) target_list="$optarg"
+@@ -1735,6 +1740,7 @@ disabled with --disable-FEATURE, default
+   guest-agent-msi build guest agent Windows MSI installation package
+   pie             Position Independent Executables
+   modules         modules support (non-Windows)
++  module-upgrades try to load modules from alternate paths for upgrades
+   debug-tcg       TCG debugging (default is disabled)
+   debug-info      debugging information
+   sparse          sparse checker
+@@ -1995,6 +2001,11 @@ if test "$modules" = "yes" && test "$min
+   error_exit "Modules are not available for Windows"
+ fi
+ 
++# module_upgrades is only reasonable if modules are enabled
++if test "$modules" = "no" && test "$module_upgrades" = "yes" ; then
++  error_exit "Can't enable module-upgrades as Modules are not enabled"
++fi
++
+ # Static linking is not possible with modules or PIE
+ if test "$static" = "yes" ; then
+   if test "$modules" = "yes" ; then
+@@ -6457,6 +6468,7 @@ if test "$slirp" != "no" ; then
+     echo "smbd              $smbd"
+ fi
+ echo "module support    $modules"
++echo "alt path mod load $module_upgrades"
+ echo "host CPU          $cpu"
+ echo "host big endian   $bigendian"
+ echo "target list       $target_list"
+@@ -6814,6 +6826,9 @@ if test "$modules" = "yes"; then
+   echo "CONFIG_STAMP=_$( (echo $qemu_version; echo $pkgversion; cat $0) | $shacmd - | cut -f1 -d\ )" >> $config_host_mak
+   echo "CONFIG_MODULES=y" >> $config_host_mak
+ fi
++if test "$module_upgrades" = "yes"; then
++  echo "CONFIG_MODULE_UPGRADES=y" >> $config_host_mak
++fi
+ if test "$have_x11" = "yes" && test "$need_x11" = "yes"; then
+   echo "CONFIG_X11=y" >> $config_host_mak
+   echo "X11_CFLAGS=$x11_cflags" >> $config_host_mak
+--- a/util/module.c
++++ b/util/module.c
+@@ -19,6 +19,9 @@
+ #endif
+ #include "qemu/queue.h"
+ #include "qemu/module.h"
++#ifdef CONFIG_MODULE_UPGRADES
++#include "qemu-version.h"
++#endif
+ 
+ typedef struct ModuleEntry
+ {
+@@ -163,6 +166,9 @@ bool module_load_one(const char *prefix,
+ #ifdef CONFIG_MODULES
+     char *fname = NULL;
+     char *exec_dir;
++#ifdef CONFIG_MODULE_UPGRADES
++    char *version_dir;
++#endif
+     const char *search_dir;
+     char *dirs[4];
+     char *module_name;
+@@ -194,6 +200,14 @@ bool module_load_one(const char *prefix,
+     dirs[n_dirs++] = g_strdup_printf("%s", CONFIG_QEMU_MODDIR);
+     dirs[n_dirs++] = g_strdup_printf("%s/..", exec_dir ? : "");
+     dirs[n_dirs++] = g_strdup_printf("%s", exec_dir ? : "");
++
++#ifdef CONFIG_MODULE_UPGRADES
++    version_dir = g_strcanon(g_strdup(QEMU_PKGVERSION),
++                             G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "+-.~",
++                             '_');
++    dirs[n_dirs++] = g_strdup_printf("/var/run/qemu/%s", version_dir);
++#endif
++
+     assert(n_dirs <= ARRAY_SIZE(dirs));
+ 
+     g_free(exec_dir);
diff --git a/debian/patches/ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch b/debian/patches/ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch
new file mode 100644
index 0000000..6ef5d49
--- /dev/null
+++ b/debian/patches/ubuntu/lp-1847361-vhost-correctly-turn-on-VIRTIO_F_IOMMU_PLATFORM.patch
@@ -0,0 +1,61 @@
+From f7ef7e6e3ba6e994e070cc609eb154339d1c4a11 Mon Sep 17 00:00:00 2001
+From: Jason Wang <[e-mail]>
+Date: Mon, 2 Mar 2020 12:24:54 +0800
+Subject: [PATCH] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM
+
+We turn on device IOTLB via VIRTIO_F_IOMMU_PLATFORM unconditionally on
+platform without IOMMU support. This can lead unnecessary IOTLB
+transactions which will damage the performance.
+
+Fixing this by check whether the device is backed by IOMMU and disable
+device IOTLB.
+
+Reported-by: Halil Pasic <[e-mail]>
+Tested-by: Halil Pasic <[e-mail]>
+Reviewed-by: Halil Pasic <[e-mail]>
+Signed-off-by: Jason Wang <[e-mail]>
+Message-Id: <[e-mail]>
+Reviewed-by: Michael S. Tsirkin <[e-mail]>
+Signed-off-by: Michael S. Tsirkin <[e-mail]>
+
+Origin: upstream, https://git.qemu.org/?p=qemu.git;a=commit;h=f7ef7e6e3ba6e994e070cc609eb154339d1c4a11
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1847361
+Last-Update: 2020-03-13
+
+---
+ hw/virtio/vhost.c | 12 +++++++++++-
+ 1 file changed, 11 insertions(+), 1 deletion(-)
+
+diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
+index 0d226dae10..01ebe12f28 100644
+--- a/hw/virtio/vhost.c
++++ b/hw/virtio/vhost.c
+@@ -290,7 +290,14 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev)
+ {
+     VirtIODevice *vdev = dev->vdev;
+ 
+-    return virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
++    /*
++     * For vhost, VIRTIO_F_IOMMU_PLATFORM means the backend support
++     * incremental memory mapping API via IOTLB API. For platform that
++     * does not have IOMMU, there's no need to enable this feature
++     * which may cause unnecessary IOTLB miss/update trnasactions.
++     */
++    return vdev->dma_as != &address_space_memory &&
++           virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
+ }
+ 
+ static void *vhost_memory_map(struct vhost_dev *dev, hwaddr addr,
+@@ -765,6 +772,9 @@ static int vhost_dev_set_features(struct vhost_dev *dev,
+     if (enable_log) {
+         features |= 0x1ULL << VHOST_F_LOG_ALL;
+     }
++    if (!vhost_dev_has_iommu(dev)) {
++        features &= ~(0x1ULL << VIRTIO_F_IOMMU_PLATFORM);
++    }
+     r = dev->vhost_ops->vhost_set_features(dev, features);
+     if (r < 0) {
+         VHOST_OPS_DEBUG("vhost_set_features failed");
+-- 
+2.25.1
+
diff --git a/debian/qemu-block-extra.postrm.in b/debian/qemu-block-extra.postrm.in
new file mode 100644
index 0000000..ef2126a
--- /dev/null
+++ b/debian/qemu-block-extra.postrm.in
@@ -0,0 +1,43 @@
+#!/bin/sh
+# postrm script for brrr
+#
+# see: dh_installdeb(1)
+
+set -e
+
+# summary of how this script can be called:
+#        * <postrm> `remove'
+#        * <postrm> `purge'
+#        * <old-postrm> `upgrade' <new-version>
+#        * <new-postrm> `failed-upgrade' <old-version>
+#        * <new-postrm> `abort-install'
+#        * <new-postrm> `abort-install' <old-version>
+#        * <new-postrm> `abort-upgrade' <old-version>
+#        * <disappearer's-postrm> `disappear' <overwriter>
+#          <overwriter-version>
+# for details, see https://www.debian.org/doc/debian-policy/ or
+# the debian-policy package
+
+
+case "$1" in
+    purge|remove)
+        # remove .so files for still running qemu instances in /var/run
+        # for details see bug LP: #1847361
+        rm -f /var/run/qemu/@PKGVERSION@/block-*.so
+    ;;
+
+    upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
+    ;;
+
+    *)
+        echo "postrm called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/qemu-block-extra.prerm.in b/debian/qemu-block-extra.prerm.in
new file mode 100644
index 0000000..dee25a8
--- /dev/null
+++ b/debian/qemu-block-extra.prerm.in
@@ -0,0 +1,45 @@
+#!/bin/sh
+# prerm script for qemu-block-extra
+#
+# see: dh_installdeb(1)
+
+set -e
+
+# summary of how this script can be called:
+#        * <prerm> `remove'
+#        * <old-prerm> `upgrade' <new-version>
+#        * <new-prerm> `failed-upgrade' <old-version>
+#        * <conflictor's-prerm> `remove' `in-favour' <package> <new-version>
+#        * <deconfigured's-prerm> `deconfigure' `in-favour'
+#          <package-being-installed> <version> `removing'
+#          <conflicting-package> <version>
+# for details, see https://www.debian.org/doc/debian-policy/ or
+# the debian-policy package
+
+
+case "$1" in
+    remove)
+    ;;
+
+    upgrade|deconfigure)
+        # retain .so files for still running qemu instances in /var/run
+        # for details see bug LP: #1847361
+        mkdir -p /var/run/qemu/@PKGVERSION@
+        cp /usr/lib/@ARCH@/qemu/block-*.so /var/run/qemu/@PKGVERSION@/
+    ;;
+
+    failed-upgrade)
+    ;;
+
+    *)
+        echo "prerm called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/qemu-system-gui.postrm.in b/debian/qemu-system-gui.postrm.in
new file mode 100644
index 0000000..48c740a
--- /dev/null
+++ b/debian/qemu-system-gui.postrm.in
@@ -0,0 +1,44 @@
+#!/bin/sh
+# postrm script for brrr
+#
+# see: dh_installdeb(1)
+
+set -e
+
+# summary of how this script can be called:
+#        * <postrm> `remove'
+#        * <postrm> `purge'
+#        * <old-postrm> `upgrade' <new-version>
+#        * <new-postrm> `failed-upgrade' <old-version>
+#        * <new-postrm> `abort-install'
+#        * <new-postrm> `abort-install' <old-version>
+#        * <new-postrm> `abort-upgrade' <old-version>
+#        * <disappearer's-postrm> `disappear' <overwriter>
+#          <overwriter-version>
+# for details, see https://www.debian.org/doc/debian-policy/ or
+# the debian-policy package
+
+
+case "$1" in
+    purge|remove)
+        # remove .so files for still running qemu instances in /var/run
+        # for details see bug LP: #1847361
+        rm -f /var/run/qemu/@PKGVERSION@/ui-gtk.so
+        rm -f /var/run/qemu/@PKGVERSION@/audio-*.so
+    ;;
+
+    upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
+    ;;
+
+    *)
+        echo "postrm called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/qemu-system-gui.prerm.in b/debian/qemu-system-gui.prerm.in
new file mode 100644
index 0000000..3624362
--- /dev/null
+++ b/debian/qemu-system-gui.prerm.in
@@ -0,0 +1,46 @@
+#!/bin/sh
+# prerm script for qemu-system-gui
+#
+# see: dh_installdeb(1)
+
+set -e
+
+# summary of how this script can be called:
+#        * <prerm> `remove'
+#        * <old-prerm> `upgrade' <new-version>
+#        * <new-prerm> `failed-upgrade' <old-version>
+#        * <conflictor's-prerm> `remove' `in-favour' <package> <new-version>
+#        * <deconfigured's-prerm> `deconfigure' `in-favour'
+#          <package-being-installed> <version> `removing'
+#          <conflicting-package> <version>
+# for details, see https://www.debian.org/doc/debian-policy/ or
+# the debian-policy package
+
+
+case "$1" in
+    remove)
+    ;;
+
+    upgrade|deconfigure)
+        # retain .so files for still running qemu instances in /var/run
+        # for details see bug LP: #1847361
+        mkdir -p /var/run/qemu/@PKGVERSION@
+        cp /usr/lib/@ARCH@/qemu/ui-gtk.so /var/run/qemu/@PKGVERSION@/
+        cp /usr/lib/@ARCH@/qemu/audio-*.so /var/run/qemu/@PKGVERSION@/
+    ;;
+
+    failed-upgrade)
+    ;;
+
+    *)
+        echo "prerm called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/rules b/debian/rules
index 1604d33..58ed6ea 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,6 +15,9 @@ else
 VENDOR := DEBIAN
 endif
 
+AUTOGENERATED:= qemu-block-extra.prerm qemu-block-extra.postrm qemu-system-gui.prerm qemu-system-gui.postrm
+PKGVERSION := $(shell printf "Debian ${DEB_VERSION}" | tr --complement '[:alnum:]+-.~' '_')
+
 # support parallel build using DEB_BUILD_OPTIONS=parallel=N
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
   MAKEFLAGS += -j$(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
@@ -103,6 +106,12 @@ endif	# enable_linux_user
 b/configure-stamp: configure
 	dh_testdir
 
+	for f in ${AUTOGENERATED} ; do \
+        sed -e 's%@ARCH@%${DEB_HOST_MULTIARCH}%g' \
+	        -e 's%@PKGVERSION@%${PKGVERSION}%g' \
+			< debian/$$f.in  > debian/$$f ; \
+    done
+
 	# system build
 	rm -rf b/qemu; mkdir -p b/qemu
 	cd b/qemu && \
@@ -111,6 +120,7 @@ b/configure-stamp: configure
 		--${enable_linux_user}-linux-user \
 		--disable-xen \
 		--enable-modules \
+		--enable-module-upgrades \
 		$(shell sh debian/extract-config-opts \
 		    $(DEB_HOST_ARCH_OS)-$(DEB_HOST_ARCH) debian/control) \
 		$(QEMU_CONFIGURE_OPTIONS) || \
@@ -137,6 +147,7 @@ ifneq ($(filter $(DEB_HOST_ARCH),amd64 i386),)
 		--enable-xen \
 		--target-list="aarch64-softmmu arm-softmmu i386-softmmu x86_64-softmmu"
 		--enable-modules \
+		--enable-module-upgrades \
 		$(shell sh debian/extract-config-opts \
 		    $(DEB_HOST_ARCH_OS)-$(DEB_HOST_ARCH) debian/control) \
 		$(QEMU_CONFIGURE_OPTIONS) || \
@@ -489,6 +500,7 @@ clean:	debian/control
 	rm -rf b
 	find scripts/ -name '*.pyc' -delete || :
 	rm -f debian/qemu-user.1
+	rm -f $(patsubst %, debian/%, ${AUTOGENERATED})
 	dh_clean
 
 .PHONY: build clean binary-arch binary-indep binary build-arch build-indep build