Code review comment for ~paelzer/ubuntu/+source/qemu:bug-1847948-nvmeperf-1842774-z15name-bionic

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Hello Christian,

I have reviewed all the changes and I'm +1 on this merge with a minor clarification:

07:56 <rafaeldtinoco> IBM Z14 GA2 was a minor change for s309x-cpumodel patch.
07:56 <rafaeldtinoco> you changed it from upstream to backport
07:56 <rafaeldtinoco> i can't find any other reference to that change
07:56 <rafaeldtinoco> why its z13s GA1 instead of z14 GA2

All the rest lgtm. +1

review: Approve

« Back to merge proposal